Fix shared object ABI exports (#5144) #11032
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Ah, I thought we had a CLA in place from a few years ago, but it seems it was never followed up on. I'll get on that. |
|
@LourensVeen Please sign the CLA so that we can assign a reviewer to this PR. More information here |
|
Hi, I'm working on it, but I'm doing this at work so we have to sign the corporate version, and it has to go through channels. The text shouldn't be an issue, we're just waiting for some very busy people to have a moment to give me the official go-ahead to set it up and then to sign it. |
|
Can you also rebase this PR? We recently overhauled our CI infrastructure and our tests would fail in the current state |
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
Rebased, and I've set the CLA process in motion, that should be a signature away from passing. |
|
The CLA is signed now, and I've tried to do a rescan following the documentation, but I'm getting a 400 - That's an error - That's all we know. The URL on that page ends with I think someone at Google should be able to re-run the CLA check though, could you try? |
|
I tried again, and rescanning worked now. |
|
I think I've done all I can now. I'm not sure how it's used exactly, but perhaps the "wait for user action" label can be removed now? |
fowles
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
On some linkers, the ABI definitions in src/libprotoc.map and friends do not match all symbols that need to be exported. This causes a linker error when trying to use the resulting shared object library:
undefined reference to 'scc_info_FileDescriptorProto_google_2fprotobuf_2fdescriptor_2eproto'Quite a few people seem to be affected by this, see #5144 for discussion. It seems that yocto now applies this patch itself, but that doesn't help people building in other places (I encountered this on some HPC machines), so it would probably be good to apply it upstream as well.