Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1275 - Upgrade jsdoc #1338

Conversation

chris-grabcad
Copy link

fixes issues with using pbts on Windows platforms
with modern versions of node 12.0.0 +

I have tried this locally on the project I work on with node 12.0.0 and it fixes problems as described here

#1275 (comment)

fixes issues with using pbts on Windows platforms
with modern versionf of node 12.0.0 +
@dcodeIO
Copy link
Member

dcodeIO commented Feb 5, 2020

Thanks, sounds good. Preferring updating jsdoc over the other options, but I'm too paranoid to merge package-lock changes. Currently looking into upgrading ALL the dependencies, and seeing how that turns out.

@chris-grabcad
Copy link
Author

Ok - thanks for fixing ... I will look out for an updated version so I can stop using our local fork 👍 .

@chris-grabcad chris-grabcad deleted the issue_1275_upgrade_jsdoc branch March 12, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants