Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package browser field descriptor #1046

Merged
merged 5 commits into from
May 19, 2018
Merged

Fix package browser field descriptor #1046

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47c569e
Remove browser property from package.json
SlyryD May 18, 2018
82e7897
Test package browser field descriptor
SlyryD May 18, 2018
732d05b
Fix browser paths
SlyryD May 18, 2018
e22d342
browser index only
SlyryD May 18, 2018
5853cec
Remove browser entry
SlyryD May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"typescript"
],
"main": "index.js",
"browser": "dist/protobuf.js",
"browser": "index.js",
Copy link
Member

@dcodeIO dcodeIO May 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the browser entry can simply be removed (and it should still pick up main). As you pointed out, previous usage in the package.json was essentially wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I will do that. Thanks!

"types": "index.d.ts",
"bin": {
"pbjs": "bin/pbjs",
Expand Down