Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap read and write stats for XFS #343

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Swap read and write stats for XFS #343

merged 1 commit into from
Jan 11, 2021

Conversation

foygl
Copy link
Contributor

@foygl foygl commented Nov 20, 2020 •
edited
Loading

According to the table in https://xfs.org/index.php/Runtime_Stats, the first number of rw stats is write and the second is read. I noticed Prometheus seemed to be reporting the opposite of what I expected.

@discordianfish @pgier

@foygl
Swap read and write stats for XFS
4a77eac 
According to the table in https://xfs.org/index.php/Runtime_Stats, the first number of `rw` stats is write and the second is read. I noticed Prometheus seemed to be reporting the opposite of what I expected.

Signed-off-by: William Starling <[email protected]>
@foygl foygl force-pushed the swap-read-write-for-xfs branch from 50830b1 to 4a77eac Compare November 20, 2020 14:47
discordianfish
discordianfish approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, good catch. Thanks!

@SuperQ SuperQ merged commit d235606 into prometheus:master Jan 11, 2021
@juancb juancb mentioned this pull request Jan 13, 2021
Closed
SuperQ added a commit to prometheus/node_exporter that referenced this pull request Feb 5, 2021
@SuperQ
Release 1.1.0
524163d 
* Update Build
  - Update CircleCI orb.
  - Update CIrcleCI Machine image.
  - Use golang-builder 1.15.
* Update Go modules.
* Fixup fixtures for XFS bug.

Changes:
* [CHANGE] Improve filter flag names. #1743
* [CHANGE] Add btrfs and powersupplyclass to list of exporters enabled by default #1897
* [FEATURE] Add fibre channel collector #1786
* [FEATURE] Expose cpu bugs and flags as info metrics. #1788
* [FEATURE] Add network_route collector #1811
* [FEATURE] Add zoneinfo collector #1922
* [ENHANCEMENT] Add more InfiniBand counters #1694
* [ENHANCEMENT] Add flag to aggr ipvs metrics to avoid high cardinality metrics #1709
* [ENHANCEMENT] Adding backlog/current queue length to qdisc collector #1732
* [ENHANCEMENT] Include TCP OutRsts in netstat metrics #1733
* [ENHANCEMENT] Add pool size to entropy collector #1753
* [ENHANCEMENT] Remove CGO dependencies for OpenBSD amd64 #1774
* [ENHANCEMENT] bcache: add writeback_rate_debug stats #1658
* [ENHANCEMENT] Add check state for mdadm arrays via node_md_state metric #1810
* [ENHANCEMENT] Expose XFS inode statistics #1870
* [ENHANCEMENT] Expose zfs zpool state #1878
* [ENHANCEMENT] Added an ability to pass collector.supervisord.url via SUPERVISORD_URL environment variable #1947
* [BUGFIX] filesystem_freebsd: Fix label values #1728
* [BUGFIX] Fix various procfs parsing errors #1735
* [BUGFIX] Handle no data from powersupplyclass #1747
* [BUGFIX] udp_queues_linux.go: s/upd/udp/ in two error strings #1769
* [BUGFIX] Fix node_scrape_collector_success behaviour #1816
* [BUGFIX] Fix NodeRAIDDegraded to not use a string rule expressions #1827
* [BUGFIX] fix: node_md_disks state label from fail to failed #1862
* [BUGFIX] Handle EPERM for syscall in timex collector #1938
* [BUGFIX] bcache: fix typo #1943
* [BUGFIX] Fix XFS read/write stats (prometheus/procfs#343)

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ SuperQ mentioned this pull request Feb 5, 2021
Merged
SuperQ added a commit to prometheus/node_exporter that referenced this pull request Feb 5, 2021
@SuperQ
Release 1.1.0
a37d3f6 
* Update Build
  - Update CircleCI orb.
  - Update CIrcleCI Machine image.
  - Use golang-builder 1.15.
* Update Go modules.
* Fixup fixtures for XFS bug.

NOTE: We have improved some of the flag naming conventions (PR #1743). The old names are
      deprecated and will be removed in 2.0. They will continue to work for backwards
      compatibility.

* [CHANGE] Improve filter flag names #1743
* [CHANGE] Add btrfs and powersupplyclass to list of exporters enabled by default #1897
* [FEATURE] Add fibre channel collector #1786
* [FEATURE] Expose cpu bugs and flags as info metrics. #1788
* [FEATURE] Add network_route collector #1811
* [FEATURE] Add zoneinfo collector #1922
* [ENHANCEMENT] Add more InfiniBand counters #1694
* [ENHANCEMENT] Add flag to aggr ipvs metrics to avoid high cardinality metrics #1709
* [ENHANCEMENT] Adding backlog/current queue length to qdisc collector #1732
* [ENHANCEMENT] Include TCP OutRsts in netstat metrics #1733
* [ENHANCEMENT] Add pool size to entropy collector #1753
* [ENHANCEMENT] Remove CGO dependencies for OpenBSD amd64 #1774
* [ENHANCEMENT] bcache: add writeback_rate_debug stats #1658
* [ENHANCEMENT] Add check state for mdadm arrays via node_md_state metric #1810
* [ENHANCEMENT] Expose XFS inode statistics #1870
* [ENHANCEMENT] Expose zfs zpool state #1878
* [ENHANCEMENT] Added an ability to pass collector.supervisord.url via SUPERVISORD_URL environment variable #1947
* [BUGFIX] filesystem_freebsd: Fix label values #1728
* [BUGFIX] Fix various procfs parsing errors #1735
* [BUGFIX] Handle no data from powersupplyclass #1747
* [BUGFIX] udp_queues_linux.go: change upd to udp in two error strings #1769
* [BUGFIX] Fix node_scrape_collector_success behaviour #1816
* [BUGFIX] Fix NodeRAIDDegraded to not use a string rule expressions #1827
* [BUGFIX] Fix node_md_disks state label from fail to failed #1862
* [BUGFIX] Handle EPERM for syscall in timex collector #1938
* [BUGFIX] bcache: fix typo in a metric name #1943
* [BUGFIX] Fix XFS read/write stats (prometheus/procfs#343)

Signed-off-by: Ben Kochie <[email protected]>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Aug 19, 2022
@iamleot
node_exporter: Update to 1.3.1
17a09ce 
Changes:
## 1.3.1 / 2021-12-01

* [BUGFIX] Handle nil CPU thermal power status on M1
* [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE.
* [BUGFIX] Sanitize UTF-8 in dmi collector

## 1.3.0 / 2021-10-20

NOTE: In order to support globs in the textfile collector path, filenames exposed by
      `node_textfile_mtime_seconds` now contain the full path name.

* [CHANGE] Add path label to rapl collector
* [CHANGE] Exclude filesystems under /run/credentials
* [CHANGE] Add TCPTimeouts to netstat default filter
* [FEATURE] Add lnstat collector for metrics from /proc/net/stat/
* [FEATURE] Add darwin powersupply collector
* [FEATURE] Add support for monitoring GPUs on Linux
* [FEATURE] Add Darwin thermal collector
* [FEATURE] Add os release collector
* [FEATURE] Add netdev.address-info collector
* [FEATURE] Add clocksource metrics to time collector
* [ENHANCEMENT] Support glob textfile collector directories
* [ENHANCEMENT] ethtool: Expose node_ethtool_info metric
* [ENHANCEMENT] Use include/exclude flags for ethtool filtering
* [ENHANCEMENT] Add flag to disable guest CPU metrics
* [ENHANCEMENT] Add DMI collector
* [ENHANCEMENT] Add threads metrics to processes collector
* [ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector
* [ENHANCMMENT] Add TCPTimeouts to netstat default filter
* [ENHANCMMENT] Use SysctlTimeval for boottime collector on BSD
* [BUGFIX] ethtool: Sanitize metric names
* [BUGFIX] Fix ethtool collector for multiple interfaces
* [BUGFIX] Fix possible panic on macOS
* [BUGFIX] Collect flag_info and bug_info only for one core
* [BUGFIX] Prevent duplicate ethtool metric names

## 1.2.2 / 2021-08-06

* [BUGFIX] Fix processes collector long int parsing

## 1.2.1 / 2021-07-23

* [BUGFIX] Fix zoneinfo parsing prometheus/procfs#386
* [BUGFIX] Fix nvme collector log noise
* [BUGFIX] Fix rapl collector log noise

## 1.2.0 / 2021-07-15

NOTE: Ignoring invalid network speed will be the default in 2.x
NOTE: Filesystem collector flags have been renamed. `--collector.filesystem.ignored-mount-points` is now `--collector.filesystem.mount-points-exclude` and `--collector.filesystem.ignored-fs-types` is now `--collector.filesystem.fs-types-exclude`. The old flags will be removed in 2.x.

* [CHANGE] Rename filesystem collector flags to match other collectors
* [CHANGE] Make node_exporter print usage to STDOUT
* [FEATURE] Add conntrack statistics metrics
* [FEATURE] Add ethtool stats collector
* [FEATURE] Add flag to ignore network speed if it is unknown
* [FEATURE] Add tapestats collector for Linux
* [FEATURE] Add nvme collector
* [ENHANCEMENT] Add ErrorLog plumbing to promhttp
* [ENHANCEMENT] Add more Infiniband counters
* [ENHANCEMENT] netclass: retrieve interface names and filter before parsing
* [ENHANCEMENT] Add time zone offset metric
* [BUGFIX] Handle errors from disabled PSI subsystem
* [BUGFIX] Fix panic when using backwards compatible flags
* [BUGFIX] Fix wrong value for OpenBSD memory buffer cache
* [BUGFIX] Only initiate collectors once
* [BUGFIX] Handle small backwards jumps in CPU idle

## 1.1.2 / 2021-03-05

* [BUGFIX] Handle errors from disabled PSI subsystem
* [BUGFIX] Sanitize strings from /sys/class/power_supply
* [BUGFIX] Silence missing netclass errors

## 1.1.1 / 2021-02-12

* [BUGFIX] Fix ineffassign issue
* [BUGFIX] Fix some noisy log lines

## 1.1.0 / 2021-02-05

NOTE: We have improved some of the flag naming conventions (PR #1743). The old names are
      deprecated and will be removed in 2.0. They will continue to work for backwards
      compatibility.

* [CHANGE] Improve filter flag names
* [CHANGE] Add btrfs and powersupplyclass to list of exporters enabled by default
* [FEATURE] Add fibre channel collector
* [FEATURE] Expose cpu bugs and flags as info metrics.
* [FEATURE] Add network_route collector
* [FEATURE] Add zoneinfo collector
* [ENHANCEMENT] Add more InfiniBand counters
* [ENHANCEMENT] Add flag to aggr ipvs metrics to avoid high cardinality metrics
* [ENHANCEMENT] Adding backlog/current queue length to qdisc collector
* [ENHANCEMENT] Include TCP OutRsts in netstat metrics
* [ENHANCEMENT] Add pool size to entropy collector
* [ENHANCEMENT] Remove CGO dependencies for OpenBSD amd64
* [ENHANCEMENT] bcache: add writeback_rate_debug stats
* [ENHANCEMENT] Add check state for mdadm arrays via node_md_state metric
* [ENHANCEMENT] Expose XFS inode statistics
* [ENHANCEMENT] Expose zfs zpool state
* [ENHANCEMENT] Added an ability to pass collector.supervisord.url via SUPERVISORD_URL environment variable
* [BUGFIX] filesystem_freebsd: Fix label values
* [BUGFIX] Fix various procfs parsing errors
* [BUGFIX] Handle no data from powersupplyclass
* [BUGFIX] udp_queues_linux.go: change upd to udp in two error strings
* [BUGFIX] Fix node_scrape_collector_success behaviour
* [BUGFIX] Fix NodeRAIDDegraded to not use a string rule expressions
* [BUGFIX] Fix node_md_disks state label from fail to failed
* [BUGFIX] Handle EPERM for syscall in timex collector
* [BUGFIX] bcache: fix typo in a metric name
* [BUGFIX] Fix XFS read/write stats (prometheus/procfs#343)
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
@foygl
Swap read and write stats for XFS (prometheus#343)
691fc05 
According to the table in https://xfs.org/index.php/Runtime_Stats, the first number of `rw` stats is write and the second is read. I noticed Prometheus seemed to be reporting the opposite of what I expected.

Signed-off-by: William Starling <[email protected]>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
@SuperQ @oblitorum
Release 1.1.0
8ef827f 
* Update Build
  - Update CircleCI orb.
  - Update CIrcleCI Machine image.
  - Use golang-builder 1.15.
* Update Go modules.
* Fixup fixtures for XFS bug.

NOTE: We have improved some of the flag naming conventions (PR prometheus#1743). The old names are
      deprecated and will be removed in 2.0. They will continue to work for backwards
      compatibility.

* [CHANGE] Improve filter flag names prometheus#1743
* [CHANGE] Add btrfs and powersupplyclass to list of exporters enabled by default prometheus#1897
* [FEATURE] Add fibre channel collector prometheus#1786
* [FEATURE] Expose cpu bugs and flags as info metrics. prometheus#1788
* [FEATURE] Add network_route collector prometheus#1811
* [FEATURE] Add zoneinfo collector prometheus#1922
* [ENHANCEMENT] Add more InfiniBand counters prometheus#1694
* [ENHANCEMENT] Add flag to aggr ipvs metrics to avoid high cardinality metrics prometheus#1709
* [ENHANCEMENT] Adding backlog/current queue length to qdisc collector prometheus#1732
* [ENHANCEMENT] Include TCP OutRsts in netstat metrics prometheus#1733
* [ENHANCEMENT] Add pool size to entropy collector prometheus#1753
* [ENHANCEMENT] Remove CGO dependencies for OpenBSD amd64 prometheus#1774
* [ENHANCEMENT] bcache: add writeback_rate_debug stats prometheus#1658
* [ENHANCEMENT] Add check state for mdadm arrays via node_md_state metric prometheus#1810
* [ENHANCEMENT] Expose XFS inode statistics prometheus#1870
* [ENHANCEMENT] Expose zfs zpool state prometheus#1878
* [ENHANCEMENT] Added an ability to pass collector.supervisord.url via SUPERVISORD_URL environment variable prometheus#1947
* [BUGFIX] filesystem_freebsd: Fix label values prometheus#1728
* [BUGFIX] Fix various procfs parsing errors prometheus#1735
* [BUGFIX] Handle no data from powersupplyclass prometheus#1747
* [BUGFIX] udp_queues_linux.go: change upd to udp in two error strings prometheus#1769
* [BUGFIX] Fix node_scrape_collector_success behaviour prometheus#1816
* [BUGFIX] Fix NodeRAIDDegraded to not use a string rule expressions prometheus#1827
* [BUGFIX] Fix node_md_disks state label from fail to failed prometheus#1862
* [BUGFIX] Handle EPERM for syscall in timex collector prometheus#1938
* [BUGFIX] bcache: fix typo in a metric name prometheus#1943
* [BUGFIX] Fix XFS read/write stats (prometheus/procfs#343)

Signed-off-by: Ben Kochie <[email protected]>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
@SuperQ @oblitorum
Release 1.1.0
1cb6a3f 
* Update Build
  - Update CircleCI orb.
  - Update CIrcleCI Machine image.
  - Use golang-builder 1.15.
* Update Go modules.
* Fixup fixtures for XFS bug.

NOTE: We have improved some of the flag naming conventions (PR prometheus#1743). The old names are
      deprecated and will be removed in 2.0. They will continue to work for backwards
      compatibility.

* [CHANGE] Improve filter flag names prometheus#1743
* [CHANGE] Add btrfs and powersupplyclass to list of exporters enabled by default prometheus#1897
* [FEATURE] Add fibre channel collector prometheus#1786
* [FEATURE] Expose cpu bugs and flags as info metrics. prometheus#1788
* [FEATURE] Add network_route collector prometheus#1811
* [FEATURE] Add zoneinfo collector prometheus#1922
* [ENHANCEMENT] Add more InfiniBand counters prometheus#1694
* [ENHANCEMENT] Add flag to aggr ipvs metrics to avoid high cardinality metrics prometheus#1709
* [ENHANCEMENT] Adding backlog/current queue length to qdisc collector prometheus#1732
* [ENHANCEMENT] Include TCP OutRsts in netstat metrics prometheus#1733
* [ENHANCEMENT] Add pool size to entropy collector prometheus#1753
* [ENHANCEMENT] Remove CGO dependencies for OpenBSD amd64 prometheus#1774
* [ENHANCEMENT] bcache: add writeback_rate_debug stats prometheus#1658
* [ENHANCEMENT] Add check state for mdadm arrays via node_md_state metric prometheus#1810
* [ENHANCEMENT] Expose XFS inode statistics prometheus#1870
* [ENHANCEMENT] Expose zfs zpool state prometheus#1878
* [ENHANCEMENT] Added an ability to pass collector.supervisord.url via SUPERVISORD_URL environment variable prometheus#1947
* [BUGFIX] filesystem_freebsd: Fix label values prometheus#1728
* [BUGFIX] Fix various procfs parsing errors prometheus#1735
* [BUGFIX] Handle no data from powersupplyclass prometheus#1747
* [BUGFIX] udp_queues_linux.go: change upd to udp in two error strings prometheus#1769
* [BUGFIX] Fix node_scrape_collector_success behaviour prometheus#1816
* [BUGFIX] Fix NodeRAIDDegraded to not use a string rule expressions prometheus#1827
* [BUGFIX] Fix node_md_disks state label from fail to failed prometheus#1862
* [BUGFIX] Handle EPERM for syscall in timex collector prometheus#1938
* [BUGFIX] bcache: fix typo in a metric name prometheus#1943
* [BUGFIX] Fix XFS read/write stats (prometheus/procfs#343)

Signed-off-by: Ben Kochie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordianfish discordianfish discordianfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foygl @discordianfish @SuperQ