Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZFS for FreeBSD #1063

Closed
sachaz opened this issue Sep 8, 2018 · 14 comments
Closed

ZFS for FreeBSD #1063

sachaz opened this issue Sep 8, 2018 · 14 comments

Comments

@sachaz
Copy link

sachaz commented Sep 8, 2018

It's a surprise to see the ZFS working on Linux and not FreeBSD, could it be considered ?

@discordianfish
Copy link
Member

For some reason we removed freebsd support from the zfs PR. Might be because it required root. But in general we're open to adding this as long as it's possible under the constraints we have: https://github.com/prometheus/node_exporter/blob/master/CONTRIBUTING.md#collector-implementation-guidelines

@dominikh I read in #369 that you wanted to look into adding freebsd back?

@dominikh
Copy link
Contributor

I'm afraid I don't have the time to do that anymore.

@discordianfish
Copy link
Member

@dominikh Totally understand that. Any chance you remember some details why we didn't include it in the first place? Is there some blockers that would need to be addressed first?

@dominikh
Copy link
Contributor

@discordianfish
Copy link
Member

@dominikh Ah, thanks!

So yeah, we would like to include zfs support on freebsd as long as it doesn't require executing some binary or root privileges.

@sachaz
Copy link
Author

sachaz commented Sep 19, 2018

thanks !

@zachfi
Copy link
Contributor

zachfi commented Sep 19, 2018

I was looking for zfs bindings in golang last night, but none seem to support FreeBSD. Does anyone know of one that I've missed? FreeBSD seems to use libzfs_core.h, while the linux folks are using libzfs.h, and the object signatures seem to be different in the https://github.com/bicomsystems/go-libzfs project, that I wasn't able to compile the package.

@SuperQ SuperQ added the platform/FreeBSD FreeBSD specific issue label Oct 1, 2018
@derekmarcotte
Copy link
Contributor

For what it's worth, there is this: https://github.com/mmatuska/zfs-stats/blob/master/zfs-stats

Most, if not all, of the ZFS cache stats are exposed via sysctl on FreeBSD.

The structures used in the referenced script are not up to date, and give some weird values around the L2ARC, for example. I was definitely planning to add this, once we started building out more comprehensive dashboards.

I could start poking now though, if this is interesting?

@discordianfish
Copy link
Member

@derekmarcotte Yeah would be great to have this!

@ltning
Copy link

ltning commented May 19, 2019

Yes please. Any progress here?

@derekmarcotte
Copy link
Contributor

Hi - sorry for the radio silence. The node_exporter work isn't as high a priority for my organization at the moment, so it's been my free time work, and hasn't been on my radar at the moment. I'll see how picking it up again goes this month.

@ltning
Copy link

ltning commented Jun 5, 2019

That would be awesome. We are pretty heavy users, let me know if there is anything we can do to help or encourage :)

@ghost
Copy link

ghost commented Jul 2, 2019

Is there any ETA on this? Would be very useful

derekmarcotte added a commit to derekmarcotte/node_exporter that referenced this issue Jul 3, 2019
Based on the solaris implementation.  There's a lot of other sysctls
available on FreeBSD that aren't reported here.  It'll be easy to add,
if they're useful.  All of the sysctls are uint64.

Signed-off-by: Derek Marcotte <[email protected]>
SuperQ pushed a commit that referenced this issue Jul 3, 2019
Based on the solaris implementation.  There's a lot of other sysctls
available on FreeBSD that aren't reported here.  It'll be easy to add,
if they're useful.  All of the sysctls are uint64.

Signed-off-by: Derek Marcotte <[email protected]>
@discordianfish
Copy link
Member

Closed by #1394

oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this issue Apr 9, 2024
Based on the solaris implementation.  There's a lot of other sysctls
available on FreeBSD that aren't reported here.  It'll be easy to add,
if they're useful.  All of the sysctls are uint64.

Signed-off-by: Derek Marcotte <[email protected]>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this issue Apr 9, 2024
Based on the solaris implementation.  There's a lot of other sysctls
available on FreeBSD that aren't reported here.  It'll be easy to add,
if they're useful.  All of the sysctls are uint64.

Signed-off-by: Derek Marcotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants