Useragent for OAuth2 #387
Merged
Useragent for OAuth2 #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clayton-gonsalves <[email protected]>
Signed-off-by: Julien Pivotto <[email protected]>
Signed-off-by: Julien Pivotto <[email protected]>
cig2312
reviewed
Jul 4, 2022
config/http_config.go
Outdated
| @@ -405,6 +406,13 @@ func WithIdleConnTimeout(timeout time.Duration) HTTPClientOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithIdleConnTimeout allows setting the user agent. | |||
There was a problem hiding this comment.
Suggested change
| // WithIdleConnTimeout allows setting the user agent. | |
| // WithUserAgent allows setting the user agent. |
cig2312
approved these changes
Jul 4, 2022
|
Hey @roidelapluie, can we get this merged? |
Signed-off-by: Julien Pivotto <[email protected]>
cig2312
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.