Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra Replication insert #231

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Remove extra Replication insert #231

merged 2 commits into from
Apr 15, 2024

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Apr 15, 2024

Was present even before refactoring in the insertion test, but after splitting it into multiple tests I noticed that it not needed, all entities already spawned with this component.

Was present even before refactoring in the `insertion` test, but after
splitting it into multiple tests I noticed that it not needed, all
entities already spawned with this component.
@Shatur Shatur requested a review from UkoeHB April 15, 2024 23:10
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.62%. Comparing base (70db508) to head (60a3836).

❗ Current head 60a3836 differs from pull request most recent head 9f74e4b. Consider uploading reports for the commit 9f74e4b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   90.62%   90.62%           
=======================================
  Files          28       28           
  Lines        1718     1718           
=======================================
  Hits         1557     1557           
  Misses        161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur Shatur enabled auto-merge (squash) April 15, 2024 23:31
@Shatur Shatur merged commit 3cbbfa9 into master Apr 15, 2024
5 checks passed
@Shatur Shatur deleted the remove-extra-insert branch April 15, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants