Refactor tests #230
Merged
Refactor tests #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current integration tests categorization doesn't scale well for the amount of tests cases we have. I made the following changes to address it: 1. Split `init_replication` test into `removals`, `insertion`, `spawn` and `despawn`. 2. Split insertion and removal test with multiple components into separate tests. 3. Thanks to code coverage I found a missing test case for spawning an entity from a mapped component, added.
UkoeHB
approved these changes
Apr 15, 2024
I did a little refactoring right before committing and accidentally made a mistake with the check.
UkoeHB
approved these changes
Apr 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 90.44% 90.62% +0.18%
==========================================
Files 28 28
Lines 1717 1718 +1
==========================================
+ Hits 1553 1557 +4
+ Misses 164 161 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current integration tests categorization doesn't scale well for the amount of tests cases we have. I made the following changes to address it:
init_replicationtest intoremovals,insertion,spawnanddespawn.