"Fix" UB [skip ci]

src/core/replication_fns/command_fns.rs

@@ -1,12 +1,12 @@
-use std::io::Cursor;
+use std::{io::Cursor, mem};
 
 use bevy::{
     ecs::{component::ComponentId, system::EntityCommands},
     prelude::*,
     ptr::Ptr,
 };
 
-use super::serde_fns::SerdeFns;
+use super::serde_fns::{DeserializeInPlaceFn, SerdeFns};
 use crate::{
     client::client_mapper::{ClientMapper, ServerEntityMap},
     core::replicon_tick::RepliconTick,
@@ -110,7 +110,8 @@ unsafe fn write<C: Component>(
     };
 
     if let Some(mut component) = entity.get_mut::<C>() {
-        rule_fns.deserialize_in_place(&mut component, cursor, &mut mapper)?;
+        let deserialize: DeserializeInPlaceFn<C> = mem::transmute(rule_fns.deserialize_in_place);
+        (deserialize)(&mut component, cursor, &mut mapper)?;
     } else {
         let component: C = rule_fns.deserialize(cursor, &mut mapper)?;
         commands.entity(entity.id()).insert(component);

src/core/replication_fns/serde_fns.rs

@@ -11,7 +11,7 @@ pub struct SerdeFns {
     commands_id: CommandFnsId,
     serialize: unsafe fn(),
     deserialize: unsafe fn(),
-    deserialize_in_place: unsafe fn(),
+    pub deserialize_in_place: unsafe fn(),
 }
 
 impl SerdeFns {
@@ -47,16 +47,6 @@ impl SerdeFns {
         (deserialize)(cursor, mapper)
     }
 
-    pub unsafe fn deserialize_in_place<C>(
-        &self,
-        component: &mut C,
-        cursor: &mut Cursor<&[u8]>,
-        mapper: &mut ClientMapper,
-    ) -> bincode::Result<()> {
-        let deserialize: DeserializeInPlaceFn<C> = mem::transmute(self.deserialize_in_place);
-        (deserialize)(component, cursor, mapper)
-    }
-
     pub(crate) fn commands_id(&self) -> CommandFnsId {
         self.commands_id
     }