Use unwrap_or_else to avoid branch duplication [skip ci] (#229)

src/core/replication_rules.rs

@@ -185,10 +185,11 @@ pub struct ReplicationRules(Vec<ReplicationRule>);
 impl ReplicationRules {
     /// Inserts a new rule, maintaining sorting by their priority in descending order.
     pub fn insert(&mut self, rule: ReplicationRule) {
-        match self.binary_search_by_key(&Reverse(rule.priority), |rule| Reverse(rule.priority)) {
-            Ok(index) => self.0.insert(index, rule),
-            Err(index) => self.0.insert(index, rule),
-        };
+        let index = self
+            .binary_search_by_key(&Reverse(rule.priority), |rule| Reverse(rule.priority))
+            .unwrap_or_else(|index| index);
+
+        self.0.insert(index, rule);
     }
 }
 
@@ -370,8 +371,8 @@ mod tests {
             .replicate::<ComponentD>();
 
         let replication_rules = app.world.resource::<ReplicationRules>();
-        let lens: Vec<_> = replication_rules.iter().map(|rule| rule.priority).collect();
-        assert_eq!(lens, [2, 2, 1, 1, 1, 1]);
+        let priorities: Vec<_> = replication_rules.iter().map(|rule| rule.priority).collect();
+        assert_eq!(priorities, [2, 2, 1, 1, 1, 1]);
     }
 
     #[derive(Serialize, Deserialize, Component)]