Expose FluentSerializer.serializeExpression #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
force-pushed
the
expose-serializeExpression
branch
from
be7ff8f to
0dbdc3a
Compare
|
@mathjazz This exposes the |
zbraniecki
reviewed
Jan 24, 2018
| // A select expression with a selector. | ||
| ? `{ ${serializeSelectExpression(expr)}}` | ||
| // A variant list without a selector. | ||
| : `{${serializeSelectExpression(expr)}}`; |
There was a problem hiding this comment.
should we use a single space before and after the expression?
There was a problem hiding this comment.
This is special-cased so that there aren't any spaces around it. Consider:
-brand-name =
{ ← no space after the opening {
*[nominative] Firefox
} ← no extra space before the closing {, just the 4-space indent
zbraniecki
approved these changes
Jan 24, 2018
stasm
added a commit
to projectfluent/python-fluent
that referenced
this pull request
Jan 29, 2018
stasm
added a commit
that referenced
this pull request
Jan 31, 2018
- Implement Fluent Syntax 0.5.
- Add support for terms.
- Add support for `#`, `##` and `###` comments.
- Remove support for tags.
- Add support for `=` after the identifier in message and term
defintions.
- Forbid newlines in string expressions.
- Allow trailing comma in call expression argument lists.
In fluent-syntax 0.6.x the new Syntax 0.5 is supported alongside the old
Syntax 0.4. This should make migrations easier.
`FluentParser` will correctly parse Syntax 0.4 comments (prefixed with
`//`), sections and message definitions without the `=` after the
identifier. The one exception are tags which are no longer supported.
Please use attributed defined on terms instead.
`FluentSerializer` always serializes using the new Syntax 0.5.
- Add `AST.Placeable` (#64)
Added in Syntax Spec 0.4, `AST.Placeable` provides exact span data about
the opening and closing brace of placeables.
- Expose `FluentSerializer.serializeExpression`. (#134)
- Serialize standalone comments with surrounding white-space.
- Allow blank lines inside of messages. (#76)
- Trim trailing newline from Comments. (#77)
eemeli
pushed a commit
to mozilla/fluent-migrate
that referenced
this pull request
May 16, 2023
jfx2006
pushed a commit
to jfx2006/tb-fluent-migrate
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mathjazz wrote the following snippet for Pontoon and asked if we could expose it from
fluent-syntax.https://gist.github.com/mathjazz/4be883ea2562e2cbb59ca26beecf1e93
Yes, yes we could.