Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CNI config in k8s manifests #1726

Merged

Conversation

caseydavenport
Copy link
Member

Description

Follow on from projectcalico/cni-plugin#481

This PR updates the CNI config in each k8s manfiest to rely solely on the given kubeconfig file for k8s API connection details.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@caseydavenport caseydavenport requested a review from tmjd March 5, 2018 23:31
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I think the same changes should be made to the Canal manifests too.

@caseydavenport
Copy link
Member Author

@tmjd thanks, I've updated canal as well :)

@caseydavenport caseydavenport merged commit b57125a into projectcalico:master Mar 6, 2018
@caseydavenport caseydavenport deleted the update-manifests-k8s branch March 6, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants