-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spectate Remote Control v1 #426
Open
jmlee337
wants to merge
23
commits into
project-slippi:main
Choose a base branch
from
jmlee337:remote
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested core functionality (list broadcasts, spectate broadcasts) reconnect not yet tested UI not quite there quite a bit of v1 functionality still missing
- add dolphinId in spectate-broadcast-response - add dolphin-closed-event - add new-file-event (also tested 1hr reconnect on previous commit)
…han every 1s current Ishii sys/stat behavior only has second precision for file mod time, so comms file modifications won't be picked up if they happen in the same epoch second
`broadcasterName` is propagated to the dolphin window title so keep it the same for OBS purposes
different libraries may treat `localhost` differently on different operating systems in regards to IPv4 vs IPv6. On my machine, this ends up with the WebSocket server bound to IPv4 while a client I'm writing attempts and fails to connect via IPv6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Spectate Remote Control v1 per the design doc
Possible Changes
Please let me know if you'd like me to
spectate.worker.ts
andspectate_manager.ts
frombroadcast/
tocommon/
or something like thatScreenshots
Spectate Remote Control server: WebSocket API
(accepts only 1 connection at a time)
spectate-protocol
spectating-broadcasts-event
(sent once only when a client connects)
new-file-event
game-end-event
dolphin-closed-event
list-broadcasts-request
spectate-broadcast-request
if
dolphinId
is not specified, spectating will begin in a new dolphin windowif
dolphinId
is specified, spectating will begin in the existing dolphin window with that id (if one exists), or a new dolphin window (if none exists)err
Request errors are denoted by the presence of an
err
field in the response