Skip to content

fix: don't show Wiis that can't be connected to in the scanner #2202

fix: don't show Wiis that can't be connected to in the scanner

fix: don't show Wiis that can't be connected to in the scanner #2202

Triggered via push September 16, 2024 04:06
Status Success
Total duration 15m 51s
Artifacts 3

build.yml

on: push
Skip Duplicate Runs
5s
Skip Duplicate Runs
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
Test on node 18.x and ubuntu-latest
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4, actions/setup-node@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test on node 18.x and ubuntu-latest: src/broadcast/broadcast.worker.interface.ts#L36
Avoid using promises inside of callbacks
Test on node 18.x and ubuntu-latest: src/renderer/lib/hooks/use_mousetrap.ts#L32
React Hook useEffect has a missing dependency: 'evtType'. Either include it or remove the dependency array
Test on node 18.x and ubuntu-latest: src/renderer/lib/hooks/use_settings.ts#L92
React Hook useCallback has a missing dependency: 'dolphinType'. Either include it or remove the dependency array
Test on node 18.x and ubuntu-latest: src/renderer/pages/console_mirror/add_connection_dialog/add_connection_form.tsx#L136
`'` can be escaped with `'`, `‘`, `'`, `’`
Test on node 18.x and ubuntu-latest: src/renderer/pages/quick_start/steps/verify_email_step.tsx#L116
`'` can be escaped with `'`, `‘`, `'`, `’`
Test on node 18.x and ubuntu-latest: src/renderer/pages/replays/replay_browser/file_list.tsx#L66
React Hook React.useCallback has a missing dependency: 'onClick'. Either include it or remove the dependency array
Test on node 18.x and ubuntu-latest: src/renderer/pages/replays/replay_browser/file_list.tsx#L74
React Hook React.useEffect has a missing dependency: 'setScrollRowItem'. Either include it or remove the dependency array. If 'setScrollRowItem' changes too often, find the parent component that defines it and wrap that definition in useCallback
Test on node 18.x and ubuntu-latest: src/renderer/pages/replays/replay_browser/file_list.tsx#L81
React Hook React.useEffect has a missing dependency: 'listRef'. Either include it or remove the dependency array
Test on node 18.x and ubuntu-latest: src/renderer/pages/replays/replay_file_stats/replay_file_stats.tsx#L122
`'` can be escaped with `'`, `‘`, `'`, `’`
Test on node 18.x and ubuntu-latest: src/renderer/pages/replays/replay_file_stats/replay_file_stats.tsx#L122
`'` can be escaped with `'`, `‘`, `'`, `’`
Test on node 18.x and macOS-latest
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4, actions/setup-node@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test on node 18.x and windows-latest
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4, actions/setup-node@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "macOS-latest", "ubuntu-latest", "windows-latest". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
macOS-latest Expired
203 MB
ubuntu-latest Expired
109 MB
windows-latest Expired
91 MB