Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json keywords #16

Merged
merged 1 commit into from
Jun 1, 2016
Merged

Conversation

astorije
Copy link
Contributor

@astorije astorije commented May 3, 2016

See chaijs/chaijs.github.io#34 for more.

If you're wondering why I want you to add these keywords, here is the reasoning for each one:

  • chai-plugin will let us index your plugin on the next version of the website. If you don't add this to your package.json, you wont be listed on our plugins page.
  • browser will let us know that your plugin supports the browser. Please don't add this keyword if you don't support the browser. If you don't add it we'll assume the plugin does not support browsers.

This partially fixes #15, a new release is required to fully fix it.

@joshperry
Copy link
Contributor

Awesome! Thank you for the PR, @astorije.

@joshperry joshperry merged commit b4a8c38 into prodatakey:master Jun 1, 2016
@astorije astorije deleted the patch-1 branch June 2, 2016 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dirty-chai does not appear on Chai's plugin page
2 participants