-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ActionList sub components) Convert to CSS Modules #5398
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: dcda4bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
// Find the div wrapping the "Overview" text | ||
const groupTitleWrapper = groupTitle.closest('div') | ||
|
||
console.log(window.getComputedStyle(groupTitleWrapper as Element).cssText) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this needs to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've decided to just remove this test because we have it covered with VRT. Our jest config can't read CSS from CSS Module files yet and while we should fix that, I'm not sure its a blocker for this PR.
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355538 |
🔴 golden-jobs completed with status |
Closes https://github.com/github/primer/issues/3961
👉 Please make sure to review this collapsed file as its probably the most important one: Item
Converts the following ActionList components:
VRT
There are some visual changes and bug fixes that were only possible to make in this giant PR. Sorry in advance 😄 I will showcase them below since the PR is large and won't render all images.
I have also made the decision to remove a specific VRT test that fails between default and enabled. The failure is likely due to a flex vs grid layout and very minor, and it's not something I can easily "fix" in default. I'm willing to take the risk here.
CleanShot.2024-12-11.at.12.06.59.mp4
Rollout strategy
Testing & Reviewing
Merge checklist