Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionList sub components) Convert to CSS Modules #5398

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Dec 7, 2024

Closes https://github.com/github/primer/issues/3961

👉 Please make sure to review this collapsed file as its probably the most important one: Item

Converts the following ActionList components:

  • Description
  • Group
  • Item
  • LinkItem
  • Selection
  • TrailingAction
  • Visuals

VRT

There are some visual changes and bug fixes that were only possible to make in this giant PR. Sorry in advance 😄 I will showcase them below since the PR is large and won't render all images.

before after what changed
image image inactive icon misaligned
image image divider width
image image extremely tiny padding change

I have also made the decision to remove a specific VRT test that fails between default and enabled. The failure is likely due to a flex vs grid layout and very minor, and it's not something I can easily "fix" in default. I'm willing to take the risk here.

CleanShot.2024-12-11.at.12.06.59.mp4

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 7, 2024

🦋 Changeset detected

Latest commit: dcda4bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 7, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 7, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5398 December 7, 2024 00:29 Inactive
Copy link
Contributor

github-actions bot commented Dec 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.01 KB (+0.76% 🔺)
packages/react/dist/browser.umd.js 104.41 KB (+0.87% 🔺)

// Find the div wrapping the "Overview" text
const groupTitleWrapper = groupTitle.closest('div')

console.log(window.getComputedStyle(groupTitleWrapper as Element).cssText)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to just remove this test because we have it covered with VRT. Our jest config can't read CSS from CSS Module files yet and while we should fix that, I'm not sure its a blocker for this PR.

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355538

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants