Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): update exports for UnderlinePanels #4742

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix(npm): update exports for UnderlinePanels #4742

merged 3 commits into from
Jul 16, 2024

Conversation

joshblack
Copy link
Member

Update the exports for UnderlinePanels. In the latest release, the re-export was being dropped

A list of re-exports with a single line in between for UnderlinePanels showing that no re-exports are occuring

Changelog

New

Changed

  • Update how UnderlinePanels is re-exported
  • Update TabProps and PanelProps when re-exported to be UnderlinePanelsTabProps and UnderlinePanelsPanelProps to be namespaced (let me know what you think of this!)

Removed

Rollout strategy

  • Patch release

Testing & Reviewing

  • Verify that the component is being exported correctly by verifying exports show up in the exports snapshot

@joshblack joshblack requested a review from a team as a code owner July 16, 2024 15:26
@joshblack joshblack requested a review from jonrohan July 16, 2024 15:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b626f2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.21 KB (0%)
packages/react/dist/browser.umd.js 91.54 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4742 July 16, 2024 15:31 Inactive
@joshblack joshblack requested a review from mperrotti July 16, 2024 16:15
@joshblack joshblack added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit c004fd5 Jul 16, 2024
30 checks passed
@joshblack joshblack deleted the fix/update-underline-panel-exports branch July 16, 2024 17:05
@primer primer bot mentioned this pull request Jul 16, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@Mapuppy09 Mapuppy09 mentioned this pull request Aug 19, 2024
Merged
This was referenced Sep 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @mperrotti