Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote PageHeader to Beta 🎉 #4725

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Promote PageHeader to Beta 🎉 #4725

merged 8 commits into from
Jul 19, 2024

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Jul 9, 2024 •
edited
Loading

We completed the PageHeader work and closed out the epic (internal link only)

Changelog

Changed

  • Move PageHeader to Beta status and update the component accordingly.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b89c7f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-4725 July 9, 2024 02:22 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.36 KB (+1.26% 🔺)
packages/react/dist/browser.umd.js 92.66 KB (+1.22% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4725 July 9, 2024 02:31 Inactive
@broccolinisoup broccolinisoup changed the title Promote PageHeader to Beta Promote PageHeader to Beta 🎉 Jul 9, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4725 July 9, 2024 02:47 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4725 July 15, 2024 03:27 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review July 15, 2024 03:37
@broccolinisoup broccolinisoup requested a review from a team as a code owner July 15, 2024 03:37
@broccolinisoup broccolinisoup changed the title Promote PageHeader to Beta 🎉 Promote PageHeader to Alpha 🎉 Jul 15, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4725 July 15, 2024 03:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4725 July 15, 2024 05:29 Inactive
joshblack
joshblack approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

siddharthkp
siddharthkp approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could even promote to beta

@broccolinisoup broccolinisoup changed the title Promote PageHeader to Alpha 🎉 Promote PageHeader to Beta 🎉 Jul 19, 2024
@broccolinisoup broccolinisoup added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 6db8b2f Jul 19, 2024
32 checks passed
@broccolinisoup broccolinisoup deleted the promote-pageheader-beta branch July 19, 2024 04:04
@primer primer bot mentioned this pull request Jul 19, 2024
Merged
@Mapuppy09 Mapuppy09 mentioned this pull request Aug 19, 2024
Merged
This was referenced Sep 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@siddharthkp siddharthkp siddharthkp approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

@mperrotti mperrotti Awaiting requested review from mperrotti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@broccolinisoup @siddharthkp @joshblack