Prevents text color from changing on hover for "inactive" ActionMenu.Items of the "danger" variant #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f3db868 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mperrotti
commented
Jun 7, 2024
| '[data-variant="danger"]:hover &, [data-variant="danger"]:active &': { | ||
| color: getVariantStyles(variant, disabled, inactive).hoverColor, | ||
| }, | ||
| '[data-variant="danger"]:not([aria-disabled]):not([data-inactive]):hover &, [data-variant="danger"]:active &': |
There was a problem hiding this comment.
The fact that these styles affect the color of sibling nodes is kind of weird. Should we do a refactor as part of this PR? I was afraid to touch it and break things.
There was a problem hiding this comment.
Let's wait till we refactor to CSS modules 😂
size-limit report 📦
|
langermank
approved these changes
Jun 14, 2024
Merged
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #No issue created.See Slack comment (GitHub staff only).Demo of fix
The fourth item, "Make a copy", is
variant="danger"and hasinactiveTextset. Before this change, the text color would change on hover. After this change, the text color remains the same.Before:
Kapture.2024-06-07.at.08.47.09.mp4
After:
Kapture.2024-06-07.at.08.34.08.mp4
Changelog
New
Changed
Increases specificity of the
:hoverstyles to exclude inactive items.Removed
Rollout strategy
Testing & Reviewing
Try and hover the fourth item ("Make a copy") in the menu of the ActionMenu/Features/Inactive items story. VRTs should cover regressions.
Merge checklist