-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Stack): rename spread to justify #4591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a43e3e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
langermank
approved these changes
May 14, 2024
JelloBagel
pushed a commit
that referenced
this pull request
May 16, 2024
* fix(Stack): rename spread to justify * test(e2e): regenerate snapshots with spread changed to justify * chore: add changeset --------- Co-authored-by: Josh Black <[email protected]>
This was referenced Jun 11, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4577
This seemed to be lost in the transition, but at one point we renamed
spread
tojustify
. This PR updates the CSS from usingspread
tojustify
as a result and also updates all snapshots that usespread
in the name tojustify
Changelog
New
Changed
data-spread
todata-justify
justify
instead ofspread
, regenerate snapshotsRemoved
Rollout strategy
Testing & Reviewing
justify
prop correctly updates the component in the storybook playground for Stack