Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Stack): rename spread to justify #4591

Merged
merged 3 commits into from
May 16, 2024
Merged

fix(Stack): rename spread to justify #4591

merged 3 commits into from
May 16, 2024

Conversation

joshblack
Copy link
Member

Closes #4577

This seemed to be lost in the transition, but at one point we renamed spread to justify. This PR updates the CSS from using spread to justify as a result and also updates all snapshots that use spread in the name to justify

Changelog

New

Changed

  • Change CSS that referred to data-spread to data-justify
  • Update tests to call out to justify instead of spread, regenerate snapshots

Removed

Rollout strategy

  • Patch release

Testing & Reviewing

  • Verify that the justify prop correctly updates the component in the storybook playground for Stack

@joshblack joshblack requested review from a team as code owners May 14, 2024 15:39
@joshblack joshblack requested review from tbenning and owenniblock May 14, 2024 15:39
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: a43e3e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack requested a review from langermank May 14, 2024 15:39
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.34 KB (0%)
packages/react/dist/browser.umd.js 88.65 KB (0%)

@joshblack joshblack added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 6cce7b7 May 16, 2024
33 checks passed
@joshblack joshblack deleted the 4577-justify-no-effect branch May 16, 2024 16:53
@primer primer bot mentioned this pull request May 16, 2024
JelloBagel pushed a commit that referenced this pull request May 16, 2024
* fix(Stack): rename spread to justify

* test(e2e): regenerate snapshots with spread changed to justify

* chore: add changeset

---------

Co-authored-by: Josh Black <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack justify prop has no effect
2 participants