Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6784 - Toast onRemove message #7108

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix #6784 - Toast onRemove message #7108

merged 2 commits into from
Sep 4, 2024

Conversation

lukelalo
Copy link
Contributor

@lukelalo lukelalo commented Sep 4, 2024

Defect Fixes

This PR changes the return parameters on onRemove method to pass the original message instead of changing to return _pId when existing, if the original message is there, because removeMessage.message doesn't exist when the _pId is defined. This PR fix #6784

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 0:03am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 0:03am

@melloware
Copy link
Member

Can you do the same for Messages.js it should be the same code.

@lukelalo
Copy link
Contributor Author

lukelalo commented Sep 4, 2024

Ok

@melloware melloware merged commit 2863e6c into primefaces:master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast and message onRemove argument is not a ToastMessage type when it has _pId
2 participants