Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #6820 updating activeStep does not actually change the active step #6841

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

elliotspall
Copy link
Contributor

Fix #6820

Description

Modifications to the activeStep prop had no effect on the currently active step.

Changes

  • Subscribe (via useUpdateEffect) to activeStep changes.
  • Check that the activeStep is "valid" (not less than 0 and not greater than the number of steps), and update the state.

Pitfalls

Event seems to need to be undefined (similar behaviour to prevCallback / nextCallback).

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jul 5, 2024 3:41am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jul 5, 2024 3:41am

Copy link

github-actions bot commented Jul 5, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Jul 5, 2024
@melloware melloware merged commit 1c4f944 into primefaces:master Jul 5, 2024
5 of 6 checks passed
@elliotspall elliotspall deleted the stepper_activestep branch July 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: Changes to activeStep prop does not change the step
2 participants