Fix 6631 DragDrop Tree keyboard navigation #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
I've seen that primang Tree stores nodes and droppoints together in a special p-treenode tag, I don't know if this is the only point of having an additional tag, or if I should study their example deeper and try something similar, or if we are good with this solution ? |
KirilCycle
commented
May 21, 2024
| @@ -84,17 +84,41 @@ export const UITreeNode = React.memo((props) => { | |||
| } | |||
| }; | |||
|
|
|||
| const findNextNonDroppointSibling = (nodeElement) => { | |||
There was a problem hiding this comment.
conditions can be refactored
KirilCycle
changed the title
nitrogenous
requested review from
nitrogenous,
melloware and
gucal
and removed request for
nitrogenous
melloware
added
Component: Accessibility
nitrogenous
approved these changes
May 24, 2024
There was a problem hiding this comment.
LGTM and Works Fine @gucal @melloware what do you people say?
melloware
approved these changes
May 24, 2024
|
Its good for me i was gonna refactor it slightly but i can do it after the PR is merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #6631 Skip drag points where needed