Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Stateful TreeTable #6384

Merged
merged 1 commit into from
May 16, 2024
Merged

Feat: Stateful TreeTable #6384

merged 1 commit into from
May 16, 2024

Conversation

MBelniak
Copy link
Contributor

@MBelniak MBelniak commented Apr 12, 2024 •
edited by melloware
Loading

As discussed here https://github.com/orgs/primefaces/discussions/1329#discussioncomment-8647981
@melloware

I copied most of the code from DataTable with some adjustments wherever they were needed. I see there's lots of duplicated code between TreeTable and DataTable, but I don't see any shared location designated for that.

Fix #6385

@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 1:59pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 1:59pm

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

4 similar comments
@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Apr 12, 2024
@melloware
Copy link
Member

@MBelniak I opened a ticket and linked it!

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 12, 2024
@MBelniak
Copy link
Contributor Author

@melloware when do you think you or someone from the team will be able to do a review?

@melloware
Copy link
Member

@MBelniak there is no timeline., If you need this feature i suggest your organization look to financially sponsor it through PrimeReact PRO support: https://primereact.org/support/

@nitrogenous nitrogenous self-requested a review April 25, 2024 14:17
@nitrogenous nitrogenous added Status: Pending Test Issue or pull request is being tested by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team labels Apr 25, 2024
@nitrogenous nitrogenous removed Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Test Issue or pull request is being tested by Core Team labels May 16, 2024
nitrogenous
nitrogenous approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrogenous nitrogenous merged commit 98c25fb into primefaces:master May 16, 2024
5 of 10 checks passed
@nitrogenous
Copy link
Contributor

We appreciate your contribution and thank you for your patience. As we are currently working on the next-generation version of PrimeReact, the implementation of new features has been temporarily paused and may take some time. @MBelniak

@nitrogenous nitrogenous added the Type: New Feature Issue contains a new feature or new component request label May 16, 2024
@leoo1992 leoo1992 mentioned this pull request Jun 14, 2024
Merged
@raymondhtet raymondhtet mentioned this pull request Jun 15, 2024
Merged
@nhattpn nhattpn mentioned this pull request Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrogenous nitrogenous nitrogenous approved these changes

Assignees

@nitrogenous nitrogenous

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stateful TreeTable?
3 participants
@MBelniak @melloware @nitrogenous