-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataTable: sort icons for ascending/descending swapped? #6852
DataTable: sort icons for ascending/descending swapped? #6852
Comments
This has been raised before: primefaces/primevue#4708 Some people think its OK others think its backwards :) |
Thanks for the quick reply. I understand that it's subjective. If I may share my perspective, I would prefer to stick to the convention used for years by the Windows and Mac operating systems, and use triangles like this: Feel free to ignore my suggestion and proceed as you see fit. :) Thanks again! |
Because these icons are used across 4 PrimTek libs you should really open this ticket at the PrimeIcons repo and not this project individually. as a workaround you can define your own icons in the table for sorting. |
Actually, I asked him to open a ticket here because I think the PrimeVue version is the right one. https://github.com/orgs/primefaces/discussions/2276#discussioncomment-9983658 |
oh are we using the wrong icon @onursenture ? We are on PrimeIcons 7.0.0 already? |
Yep i will fix it. |
Describe the bug
I have a question about the default sorting icon used by the DataTable component, specifically this icon:
This icon is labeled pi-sort-amount-down-alt in the PrimeReact Icons documentation.
The arrow points from smallest to largest, which I think means ascending order. But in this example, it seems to mean descending:
I might be misinterpreting the symbolic meaning of the arrow and the lines. If that is the case, could you please clarify?
If it's a bug, could you please confirm?
Thanks!
Reproducer
https://stackblitz.com/edit/vitejs-vite-apq6rx?file=src%2FApp.tsx
PrimeReact version
18.2.0
React version
18.x
Language
TypeScript
Build / Runtime
Next.js
Browser(s)
No response
Steps to reproduce the behavior
Expected behavior
I expect the icons for ascending and descending order to be swapped.
(Unless I am misinterpreting the symbols. If that is the case, I would appreciate an explanation.)
The text was updated successfully, but these errors were encountered: