Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tieredmenu : remove aria-level attribute from list item #6704

Closed
kyybo opened this issue May 29, 2024 · 2 comments · Fixed by #6705, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Closed

Tieredmenu : remove aria-level attribute from list item #6704

kyybo opened this issue May 29, 2024 · 2 comments · Fixed by #6705, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Assignees
@kyybo
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
10.7.0

Comments

@kyybo
Copy link
Contributor

kyybo commented May 29, 2024

Describe the bug

This accessibility error has already been reported and corrected in PrimeNG : primefaces/primeng#15130
Was also reported in PrimeVue : primefaces/primevue#4611

Is it possible to correct it for PrimeReact too?

Reproducer

No response

PrimeReact version

10.6.6

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@kyybo kyybo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 29, 2024
@melloware
Copy link
Member

@kyybo were you going to submit a PR? This seems like an easy one.

@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 29, 2024
@melloware melloware added this to the 10.7.0 milestone May 29, 2024
melloware added a commit to melloware/primereact that referenced this issue May 29, 2024
@melloware
Fix primefaces#6704: TieredMenu remove aria-level
ec7fcbc
@melloware melloware mentioned this issue May 29, 2024
Merged
melloware added a commit that referenced this issue May 29, 2024
@melloware
Fix #6704: TieredMenu remove aria-level (#6705)
25be452
@melloware
Copy link
Member

Nevermind i fixed it!

@nhattpn nhattpn mentioned this issue Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this issue Jul 25, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyybo kyybo

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
10.7.0
2 participants
@melloware @kyybo