Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect: Wrapper div of checkbox in multiselect item taking duplicate class name #6521

Closed
usman-j-shaikh opened this issue Apr 30, 2024 · 4 comments · Fixed by #6532, leoo1992/GeradorQRCode#27, leoo1992/GeradorQRCode#40 or mtech-31-quemistry/quemistry_client_web#3
Closed

MultiSelect: Wrapper div of checkbox in multiselect item taking duplicate class name #6521

usman-j-shaikh opened this issue Apr 30, 2024 · 4 comments · Fixed by #6532, leoo1992/GeradorQRCode#27, leoo1992/GeradorQRCode#40 or mtech-31-quemistry/quemistry_client_web#3
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.5

Comments

@usman-j-shaikh
Copy link

Describe the bug

Parent and grand parent wrapper div taking same class name, which creating css conflicts. Please check attached screen shot, in which div are highlighted.
image

Reproducer

No response

PrimeReact version

10.5.0

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

chrome 124

Steps to reproduce the behavior

  1. Click on dropdown of multiselect
  2. Inspect checkbox of multiselect
  3. Check its wrapper div class

Expected behavior

Parent and grand parent wrapper div shouldn't take same class name. Because css will apply to both.
@usman-j-shaikh usman-j-shaikh added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 30, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 1, 2024
melloware added a commit to melloware/primereact that referenced this issue May 1, 2024
@melloware
Fix primefaces#6521: Multiselect checkbox CSS class
3f40398
@melloware melloware mentioned this issue May 1, 2024
Merged
@melloware melloware added this to the 10.7.0 milestone May 1, 2024
@melloware melloware self-assigned this May 1, 2024
@melloware
Copy link
Member

Thanks PR submitted!

melloware added a commit that referenced this issue May 1, 2024
@melloware
Fix #6521: Multiselect checkbox CSS class (#6532)
ba99e3e
@ujshaikh
Copy link
Contributor

ujshaikh commented May 1, 2024

Thanks @melloware for quick support

@ujshaikh
Copy link
Contributor

ujshaikh commented May 1, 2024 •
edited
Loading

I like this package and want to do contribution as a developer. Can you please assign an issue or task to me?

@melloware
Copy link
Member

@ujshaikh great. What you can do is just comment on a ticket saying "I would like to fix this one" and I will assign that ticket to you.

@leoo1992 leoo1992 mentioned this issue May 24, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Jun 14, 2024
Merged
@raymondhtet raymondhtet mentioned this issue Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.5
3 participants
@melloware @ujshaikh @usman-j-shaikh