-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ripple: pt property is not defined in RippleProps and documentation API but work right #6469
Ripple: pt property is not defined in RippleProps and documentation API but work right #6469
Comments
In issue #5316 was one of the points (3) that I wrote about. It is possible that it was fixed only on Configuration - Ripple page but not on Ripple - ConfigurationDoc. UPD: i think that related code is there
|
@melloware, do I need to create new issue for point 1 of there (point 2 look like autogenerated code by ripple.d.ts), and another one for point 4? |
NO i reopened this issue. let me look. |
Please review my PR: #6472 |
Need doc for |
Describe the bug
RippleProps type (ripple.d.ts) is not provide pt property for pass through, but it can be used successfully, and it will be work like in documentation example, but it will cause an error in TS.
This property is not described in documentation "API" section. Documentation doesn't contains "Pass Through" section.
Section ConfigurationDoc contains code with
ripplie: false
, but says that it have to be enabled globally.Example for Custom section in StackBlitz contains code where ripple is not enabled, so example doesn't work.
Reproducer
https://stackblitz.com/edit/f1m5k3?file=tsconfig.json,src%2Fmain.jsx,src%2FApp.tsx
PrimeReact version
10.6.3
React version
18.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
No response
Steps to reproduce the behavior
Open Reproducer example in Stackblitz, file App.ts, line 9.
Expected behavior
The text was updated successfully, but these errors were encountered: