Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView: Add 'beforeTabClose' event #3312

Closed
gsaivinay opened this issue Sep 13, 2022 · 2 comments · Fixed by #3313
Closed

TabView: Add 'beforeTabClose' event #3312

gsaivinay opened this issue Sep 13, 2022 · 2 comments · Fixed by #3313
Assignees
@melloware
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
8.6.0

Comments

@gsaivinay
Copy link

Describe the feature you would like to see added

Request for a new beforeTabClose event on TabView closable tabs so that some validations based on requirements can be done and prevent closing the tab.

Is your feature request related to a problem?

This feature will help in preventing accidental closing of tabs.

Describe the solution you'd like

Function parameter to this event will return boolean and tab close activity is prevented when it return false.

Describe alternatives you have considered

No response

Additional context

No response
@gsaivinay gsaivinay added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Sep 13, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 13, 2022
@melloware melloware self-assigned this Sep 13, 2022
@melloware melloware added this to the 8.6.0 milestone Sep 13, 2022
@melloware melloware removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 13, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 13, 2022
@melloware
Fix primefaces#3312: Tabview add onBeforeTabClose/Change events
7ca8cfd
@melloware melloware mentioned this issue Sep 13, 2022
Merged
@melloware
Copy link
Member

Good suggestion. Please see my PR.

melloware added a commit to melloware/primereact that referenced this issue Sep 13, 2022
@melloware
Fix primefaces#3312: Tabview add onBeforeTabClose/Change events
fd0a3b6
@gsaivinay
Copy link
Author

@melloware thanks 😃 Never expected this speedy resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
8.6.0
Development

Successfully merging a pull request may close this issue.

Fix #3312: Tabview add onBeforeTabClose/Change events melloware/primereact
2 participants
@melloware @gsaivinay