Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(primeng/p-tabview): error on adding an item to an empty tab panel #11487

Merged
merged 1 commit into from
Aug 9, 2022
Merged

fix(primeng/p-tabview): error on adding an item to an empty tab panel #11487

merged 1 commit into from
Aug 9, 2022

Conversation

volvachev
Copy link
Contributor

@volvachev volvachev commented May 6, 2022 •
edited
Loading

Fixes #11454, #11430, #11290.

@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 7, 2022
@yigitfindikli yigitfindikli added this to the 14.0.0 milestone Jun 14, 2022
@yigitfindikli yigitfindikli modified the milestones: 14.0.0, 13.4.2, 14.0.0-rc.1 Jun 28, 2022
@yigitfindikli yigitfindikli self-requested a review June 28, 2022 12:24
@yigitfindikli yigitfindikli modified the milestones: 14.0.0, 14.Future Jul 18, 2022
@cetincakiroglu cetincakiroglu requested review from cetincakiroglu and removed request for yigitfindikli August 9, 2022 12:14
cetincakiroglu
cetincakiroglu approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@cetincakiroglu cetincakiroglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @volvachev,

Thanks for your effort and support!

@cetincakiroglu cetincakiroglu modified the milestones: 14.Future, 14.0.1 Aug 9, 2022
@cetincakiroglu cetincakiroglu merged commit 0604be1 into primefaces:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cetincakiroglu cetincakiroglu cetincakiroglu approved these changes

Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
14.0.1
Development

Successfully merging this pull request may close these issues.

Error on adding an item to an empty tab panel
3 participants
@volvachev @cetincakiroglu @yigitfindikli