-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support scp-style SSH urls for Git source #677
Conversation
Nice! We also need to add this to the https://github.com/prefix-dev/recipe-format |
I think we don't need to update examples or even docs. But it would be good to use this in one of the end-to-end tests or another test. And the lint needs fixing. Then I am happy to merge! |
Looks like there is a problem with using SSH URLs in the CI:
|
We need to add an SSH key to clone over SSH 💀 https://stackoverflow.com/questions/60222741/github-actions-and-git-clone-issue |
Hmm, well, if there is no quick way of testing that it might not matter that much. We could add a test that just makes sure that we can parse these. |
We now support:
Todo list:
closes #672