Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support scp-style SSH urls for Git source #677

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Feb 26, 2024

We now support:

source:
  git: [email protected]:killercup/cargo-edit.git

Todo list:

  • Update documentation about this new key
  • Update one of the examples to use this

closes #672

@baszalmstra
Copy link
Contributor

Nice! We also need to add this to the https://github.com/prefix-dev/recipe-format

@wolfv
Copy link
Member

wolfv commented Feb 27, 2024

I think we don't need to update examples or even docs. But it would be good to use this in one of the end-to-end tests or another test. And the lint needs fixing. Then I am happy to merge!

@orhun
Copy link
Contributor Author

orhun commented Feb 27, 2024

Looks like there is a problem with using SSH URLs in the CI:

[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

@orhun
Copy link
Contributor Author

orhun commented Feb 27, 2024

We need to add an SSH key to clone over SSH 💀

https://stackoverflow.com/questions/60222741/github-actions-and-git-clone-issue

@wolfv
Copy link
Member

wolfv commented Feb 27, 2024

Hmm, well, if there is no quick way of testing that it might not matter that much. We could add a test that just makes sure that we can parse these.

@wolfv wolfv merged commit a20b905 into prefix-dev:main Feb 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that [email protected]:blabla urls' work in git source
3 participants