-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect python version was used in some parts of the solve #2481
fix: incorrect python version was used in some parts of the solve #2481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appart from the warning, this looks good to me!
We should quickly get this in a release.
Co-authored-by: Ruben Arts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, plus maybe we should add tests?
Looks good! I think we can add this example in our test_integration to make sure that we will not introduce this regression again |
Co-authored-by: Hameer Abbasi <[email protected]>
… dependencies group (prefix-dev#2459) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ix-dev#2417) Co-authored-by: Ruben Arts <[email protected]>
This fixes the over-use of the
Intepreter
in the solve, it was using it incorrectly in some parts of the resolution. This would result in weird behavior, like getting the incorrect wheels from the registry and not being to able to match them with the wheel tags, for example.Discovered because of: #771 (comment). This should now work.
Test
To test you can try:
Which did not work before and now it does.