Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eslint configuration #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefek99
Copy link
Contributor

Good starter project should have smart defaults.

Adding ESLint configuration.

@Foxandxss
Copy link
Member

I like the idea, but not sure how is "jsx" a smart default here :P

@stefek99
Copy link
Contributor Author

Yeah, I've noticed that too... Copy and paste from other docs:

eslint

"rules": {
"semi": 2
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline at the end of the file.

Copy link
Member

@phra phra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove jsx support and add a newline at the end of the file.

@phra
Copy link
Member

phra commented May 23, 2018

@stefek99 any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants