-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubMatic: Remove req.ext.prebid from bid requests #4092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm-viral-vala
force-pushed
the
UOE-11370
branch
from
December 6, 2024 09:35
2305b14
to
ba4567c
Compare
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report
|
pm-viral-vala
changed the title
pubmatic: remove req.ext.prebid from pubmatic adapter request
PubMatic: remove req.ext.prebid from pubmatic adapter request
Dec 6, 2024
pm-viral-vala
changed the title
PubMatic: remove req.ext.prebid from pubmatic adapter request
PubMatic: Removing req.ext.prebid from PubMatic Adapter
Dec 6, 2024
bsardo
changed the title
PubMatic: Removing req.ext.prebid from PubMatic Adapter
PubMatic: Remove req.ext.prebid from bid requests
Dec 13, 2024
bsardo
approved these changes
Dec 13, 2024
przemkaczmarek
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
The PubMatic Adapter is currently not utilizing the
req.ext.prebid
object from the backend. As this parameter is not being used, we can safely skip passing it in the PubMatic Adapter requests.To address this, I am raising a PR to remove the
req.ext.prebid
parameter from PubMatic requests.Let me know if you have any concerns or require further input.