Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve IGS name #4073

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Reserve IGS name #4073

merged 6 commits into from
Nov 26, 2024

Conversation

patmmccann
Copy link
Contributor

Reserves IGS as not a bidder.

It seems like this function is gone? 6aab539#diff-785f5ab5ebde657757f3b3c34bf30a939782678d61bf1ea43f844c4f22a012d9R1450

@SyntaxNode
Copy link
Contributor

SyntaxNode commented Nov 25, 2024 •
edited
Loading

Looks good. Thank you for adding this reserved name. The function you are thinking of has been refactored to allowedImpExtFields. Don't worry though, as we're about to merge in #3878 which removes that check entirely.

Actually, that's now the IsPotentialBidder function in file openrtb_ext/bidders.go and also needs to be updated.

SyntaxNode
SyntaxNode requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to IsPotentialBidder.

@patmmccann
Copy link
Contributor Author

Thanks! that explains why my search was failing

hhhjort
hhhjort approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit 748ccd0 into master Nov 26, 2024
3 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Nov 26, 2024
Closed
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Dec 16, 2024
@patmmccann @scr-oath
Reserve IGS name (prebid#4073)
16448f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhhjort hhhjort hhhjort approved these changes

@bsardo bsardo bsardo approved these changes

@SyntaxNode SyntaxNode Awaiting requested review from SyntaxNode

Assignees

@bsardo bsardo

@SyntaxNode SyntaxNode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patmmccann @SyntaxNode @bsardo @hhhjort