Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blue: Add placementId bidder param #4051

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Blue: Add placementId bidder param #4051

merged 7 commits into from
Dec 10, 2024

Conversation

samuelfabel
Copy link
Contributor

@samuelfabel samuelfabel commented Nov 12, 2024 •
edited
Loading

This pull request refers to add a new parameter placementId at the bidder-params of Blue bidder.

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@SyntaxNode SyntaxNode changed the title Add a new property called "placementId" to the Blue adapter params sc… Blue: Add a new "placementId" bidder param Nov 13, 2024
@bsardo bsardo changed the title Blue: Add a new "placementId" bidder param Blue: Add placementId bidder param Nov 22, 2024
@bsardo bsardo self-assigned this Nov 22, 2024
bsardo
bsardo reviewed Nov 22, 2024
View reviewed changes
static/bidder-params/blue.json Outdated Show resolved Hide resolved
static/bidder-params/blue.json Outdated Show resolved Hide resolved
@samuelfabel samuelfabel mentioned this pull request Nov 23, 2024
Merged
8 tasks
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0d9fd7f

blue

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blue/blue.go:20:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:28:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:49:	MakeBids	100.0%
total:								(statements)	95.8%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d32141c

blue

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blue/blue.go:20:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:28:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:49:	MakeBids	100.0%
total:								(statements)	95.8%

bsardo
bsardo reviewed Dec 4, 2024
View reviewed changes
adapters/blue/params_test.go Show resolved Hide resolved
adapters/blue/params_test.go Show resolved Hide resolved
adapters/blue/params_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 072d686

blue

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blue/blue.go:20:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:28:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:49:	MakeBids	100.0%
total:								(statements)	95.8%

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6832432

blue

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blue/blue.go:20:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:28:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:49:	MakeBids	100.0%
total:								(statements)	95.8%

@przemkaczmarek przemkaczmarek self-requested a review December 9, 2024 09:50
@bsardo bsardo merged commit a9564da into prebid:master Dec 10, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Dec 10, 2024
Open
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Dec 16, 2024
@samuelfabel @samuelfabelopencircle @scr-oath
Blue: Add placementId bidder param (prebid#4051)
611688b 
Co-authored-by: Samuel Fabel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

@bsardo bsardo bsardo approved these changes

Assignees

@bsardo bsardo

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelfabel @bsardo @przemkaczmarek @samuelfabelopencircle