Increment Package Version To v3 #4029
Conversation
There was a problem hiding this comment.
LGTM. I went through all of the files quickly in vscode webview.
I also did a search locally on the PR branch for /v3 including only *.go, Makefile, Dockerfile and there are 3310 lines added and 3310 deleted. I pointed out where the additional changes are that bring us to 3320 and 3314 added and deleted respectively for the second reviewer. I successfully started up locally.
| @@ -1,12 +1,13 @@ | |||
| package aso | |||
|
|
|||
| import ( | |||
| "github.com/stretchr/testify/assert" | |||
| "testing" | |||
There was a problem hiding this comment.
Noting +2, -1 changed lines here that are unrelated to the version package update.
| @@ -2,13 +2,14 @@ package criteo | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "testing" | |||
There was a problem hiding this comment.
Noting +2, -1 changed lines here that are unrelated to the version package update.
| "testing" | ||
|
|
There was a problem hiding this comment.
Noting +2, -1 changed lines here that are unrelated to the version package update.
| "strconv" | ||
| "time" | ||
|
|
||
| "github.com/prebid/prebid-server/v3/openrtb_ext" |
There was a problem hiding this comment.
Noting +2, -1 changed lines here that are unrelated to the version package update.
| @@ -2,7 +2,8 @@ package hookstage | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/prebid/prebid-server/v2/openrtb_ext" | |||
|
|
|||
There was a problem hiding this comment.
Noting +1 changed lines here that are unrelated to the version package update.
| @@ -2,7 +2,8 @@ package hookstage | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/prebid/prebid-server/v2/openrtb_ext" | |||
|
|
|||
There was a problem hiding this comment.
Noting +1 changed lines here that are unrelated to the version package update.
|
Thanks for the in-depth review. I ran |
Oops. We forgot to do this for v3.0.0.