GumGum: Override the default currency #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
gumgumRefer here for heat map coverage report |
Code coverage summaryNote:
gumgumRefer here for heat map coverage report |
|
@onkarvhanumante Could you please review? |
|
@minaguib @dlackty @dmitris @asweeney86 Could one of you please review? |
|
@hhhjort Could you please review this PR? |
|
@bsardo Could you please review this PR? |
bsardo
reviewed
Oct 20, 2024
adapters/gumgum/gumgum_test.go
Outdated
Comment on lines
25
to
80
|
|
||
| func TestResponseWithCurrencies(t *testing.T) { | ||
| // Test for USD currency | ||
| assertCurrencyInBidResponse(t, "USD", "USD") | ||
|
|
||
| // Test for EUR currency | ||
| assertCurrencyInBidResponse(t, "EUR", "EUR") | ||
| } | ||
|
|
||
| func assertCurrencyInBidResponse(t *testing.T, expectedCurrency string, currency string) { | ||
| // Create a GumGum bidder | ||
| bidder, buildErr := Builder(openrtb_ext.BidderGumGum, config.Adapter{ | ||
| Endpoint: "https://g2.gumgum.com/providers/prbds2s/bid"}, config.Server{ | ||
| ExternalUrl: "http://hosturl.com", | ||
| GvlID: 1, | ||
| DataCenter: "2", | ||
| }) | ||
|
|
||
| if buildErr != nil { | ||
| t.Fatalf("Builder returned unexpected error %v", buildErr) | ||
| } | ||
|
|
||
| // Create a mock BidRequest | ||
| prebidRequest := &openrtb2.BidRequest{ | ||
| Imp: []openrtb2.Imp{}, | ||
| } | ||
|
|
||
| // Create a mock BidResponse with or without currency | ||
| mockedBidResponse := &openrtb2.BidResponse{} | ||
| if currency != "" { | ||
| mockedBidResponse.Cur = currency | ||
| } | ||
|
|
||
| // Marshal the mock bid response to JSON | ||
| body, err := json.Marshal(mockedBidResponse) | ||
| if err != nil { | ||
| t.Fatalf("Failed to marshal mock bid response: %v", err) | ||
| } | ||
|
|
||
| // Create a mock ResponseData | ||
| responseData := &adapters.ResponseData{ | ||
| StatusCode: 200, | ||
| Body: body, | ||
| } | ||
|
|
||
| // Call MakeBids | ||
| bidResponse, errs := bidder.MakeBids(prebidRequest, nil, responseData) | ||
|
|
||
| // Assert no errors | ||
| if len(errs) != 0 { | ||
| t.Fatalf("Failed to make bids %v", errs) | ||
| } | ||
|
|
||
| // Assert that the currency is correctly set | ||
| assert.Equal(t, expectedCurrency, bidResponse.Currency, "Expected currency to be set to "+expectedCurrency) | ||
| } |
There was a problem hiding this comment.
The guidance is to test your adapter using the JSON test framework, in which case you can get rid of all of this and instead just copy your exemplary/banner.json test into the supplemental directory, rename it to convert-currency.json and then just add "cur": "EUR" to mockResponse.body and "currency": "EUR" to the object in the expectedBidResponses array.
There was a problem hiding this comment.
@bsardo I have addressed the above comment. Could you please review it? and thx for the review.
Code coverage summaryNote:
gumgumRefer here for heat map coverage report |
…f github.com:MartinGumGum/prebid-server into ADTS-484-Set-bid-curency-in-Prebid-Server-GO-version
Code coverage summaryNote:
gumgumRefer here for heat map coverage report |
przemkaczmarek
approved these changes
Oct 25, 2024
|
@bsardo Could you please review this PR again? Thank you! |
bsardo
changed the title
bsardo
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where bid currency from the Ad Exchange was not being set in the Prebid Server's Go version, causing the currency to default to USD in all cases. The bid currency will now be dynamically set based on the response from the Ad Exchange, ensuring proper handling of different currencies in the bidding process.