New Adapter: Connatix #3916
Merged
New Adapter: Connatix #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Adapter: Connatix
7 tasks
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
Fix content type header
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
include ipv6 in ip validation and add headers
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
|
@patrickszeleczki Please add more JSON tests (Check which lines of code are not covered by tests). We usually approve PRs when the test coverage is more than 85%. |
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
Cnx adapter improvements
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
|
@bsardo Thanks a lot for the thorough review and I really appreciate the clear suggestions for the new tests and the small improvement suggestions! 🙇 |
|
ping @bsardo @przemkaczmarek |
bsardo
reviewed
Nov 22, 2024
adapters/connatix/connatix.go
Outdated
Comment on lines
25
to
33
| uri, err := url.Parse(config.Endpoint) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| bidder := &adapter{ | ||
| uri: *uri, | ||
| } | ||
| return bidder, nil |
There was a problem hiding this comment.
I don't see any endpoint params. You can simplify this to:
bidder := &adapter{
endpoint: config.Endpoint,
}
return bidder, nil
adapters/connatix/models.go
Outdated
| ) | ||
|
|
||
| type adapter struct { | ||
| uri url.URL |
There was a problem hiding this comment.
The docs guidance is for this struct to be:
type adapter struct {
endpoint string
}
adapters/connatix/connatix.go
Outdated
Comment on lines
37
to
40
| if request.Device != nil && request.Device.IP == "" && request.Device.IPv6 == "" { | ||
| return nil, []error{&errortypes.BadInput{ | ||
| Message: "Device IP is required", | ||
| }} |
There was a problem hiding this comment.
Do you also want to report this error if request.Device == nil?
There was a problem hiding this comment.
indeed. thank you! fixed
| ) | ||
|
|
||
| const ( | ||
| maxImpsPerReq = 1 |
There was a problem hiding this comment.
Why do you have a value of 1 here?
There was a problem hiding this comment.
because right now we only support a single impression per request and it would be much simpler and clearer (for new devs too) to update this constraint when we will support multiple impressions per request
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
Small fixes to cnx adapter
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
przemkaczmarek
approved these changes
Dec 3, 2024
karimMourra
approved these changes
Dec 4, 2024
bsardo
approved these changes
Dec 4, 2024
|
@bsardo @przemkaczmarek do you have any estimate when this will be included in a release? thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: prebid/prebid.github.io#5595