PgamSSP: Add currency converter #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
pgamsspRefer here for heat map coverage report |
bsardo
changed the title
bsardo
reviewed
Oct 16, 2024
| // Check if imp comes with bid floor amount defined in a foreign currency | ||
| if imp.BidFloor > 0 && imp.BidFloorCur != "" && strings.ToUpper(imp.BidFloorCur) != "USD" { | ||
| // Convert to US dollars | ||
| convertedValue, err := reqInfo.ConvertCurrency(imp.BidFloor, imp.BidFloorCur, "USD") |
There was a problem hiding this comment.
If you encounter an error when attempting to convert, how do you want to proceed? You're currently sending the bid request with a potentially invalid floor. Are you ok with that? Do you want to halt processing and return that error? Another option is to just halt processing on that imp, append the error and continue processing the next imp.
You might also want to add a supplemental invalid imp bid floor currency JSON test to verify the behavior.
There was a problem hiding this comment.
Yes, that's right, we're fine with that. If for some reason the conversion fails, the request should be sent with the current floor
przemkaczmarek
approved these changes
Oct 24, 2024
bsardo
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.