Smaato: DOOH support #3751
Merged
Smaato: DOOH support #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
el-chuck
reviewed
Jun 14, 2024
SyntaxNode
reviewed
Jun 18, 2024
| var clickEvent string | ||
| if len(curls) > 0 { | ||
| var clicks strings.Builder | ||
| for _, clicktracker := range curls { |
There was a problem hiding this comment.
How many curls do you expect the adm to contain?
There was a problem hiding this comment.
unlikely more than 3
I believe atm we mostly supply 1
There was a problem hiding this comment.
I also changed it to only execute this logic when curls field is sent
and added quotes for onlick
cc @el-chuck
adapters/smaato/banner_test.go
Outdated
| assert.Equal(t, tt.expectedAdMarkup, adMarkup) | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
This is fine, but doesn't count towards the test coverage for our review purposes. Please ensure these cases are covered with the json test framework.
There was a problem hiding this comment.
good catch, I added one more test case curls=nil
highly unlikely that we would ever return this from the server, but better have it covered
adapters/smaato/smaato.go
Outdated
| @@ -57,7 +57,8 @@ type bidRequestExt struct { | |||
|
|
|||
| // bidExt defines Bid.Ext object for Smaato | |||
| type bidExt struct { | |||
| Duration int `json:"duration"` | |||
| Duration int `json:"duration"` | |||
| Curls []string `json:"curls"` | |||
adapters/smaato/smaato.go
Outdated
| } else { | ||
| return "", &errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Invalid ad markup %s.", adMarkup), | ||
| Message: fmt.Sprintf("X-Smt-Adtype header is missing!"), |
There was a problem hiding this comment.
Nitpick: Consider changing the ! to .. We keep to plain punctuation for errors.
Enigo
force-pushed
the
smaato_dooh_support
branch
from
c82c49f to
90a0118
Compare
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
Enigo
force-pushed
the
smaato_dooh_support
branch
from
90a0118 to
00e84b0
Compare
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
przemkaczmarek
previously approved these changes
Jul 18, 2024
Enigo
force-pushed
the
smaato_dooh_support
branch
from
00e84b0 to
0fa2b80
Compare
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
przemkaczmarek
previously approved these changes
Jul 23, 2024
Enigo
force-pushed
the
smaato_dooh_support
branch
from
0fa2b80 to
54f78bf
Compare
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
|
@przemkaczmarek @bsardo |
przemkaczmarek
approved these changes
Jul 25, 2024
bsardo
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding DOOH support for Smaato adapater