Fix: Revert JSON lib used to prepare /bidders/params response #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeronikaSolovei9
approved these changes
Nov 15, 2023
bsardo
changed the title
svamiftah
pushed a commit
to sovrn/prebid-server
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the v2.0.0 release we switched the JSON library from the standard library
encoding/jsontojson-iterthroughout PBS core, however, it had the unintended consequence of changing the response output on the/bidders/paramsendpoint from a compacted single-line response to a formatted multi-line response. This PR reverts that logic so thatencoding/jsonis used to marshal the response on that endpoint.All other endpoints were checked for a similar problem and were not affected. The
/bidders/paramsendpoint prepares its response in a different way from all other endpoints by marshalingmap[string]json.RawMessagewhile other endpoints build their response by marshaling structs.There does not appear to be a way to explicitly compact JSON using
json-iterat this time so going back to the standard library in this instance suffices for now.