adquery: added device ip and ua to bidder request #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wgalecki
commented
Nov 9, 2023
•
wgalecki
commented
- adquery: added device ip and ua to bidder request
- adquery: passing client ip as x-forwarded-for header
- adquery: updated adapter endpoint
- adquery: passing ipv6 to bidder, updated user sync config
- adquery: passing page url to bidder
Code coverage summaryNote:
adqueryRefer here for heat map coverage report |
wgalecki
changed the title
Code coverage summaryNote:
adqueryRefer here for heat map coverage report |
|
Hey, sorry for the force-pushes, identified some minor issues and wanted to fix them to make the review process smoother. |
Code coverage summaryNote:
adqueryRefer here for heat map coverage report |
go.mod
Outdated
There was a problem hiding this comment.
Can you please undo changes made to go.mod?
There was a problem hiding this comment.
Yes, sorry about that, I also removed the test directory which I commited inadvertently.
* adquery: added device ip and ua to bidder request * adquery: passing client ip as x-forwarded-for header * adquery: updated adapter endpoint * adquery: passing ipv6 to bidder, updated user sync config * adquery: passing page url to bidder
Code coverage summaryNote:
adqueryRefer here for heat map coverage report |
| endpoint: "https://bidder.adquery.io/prebid/bid" | ||
| endpoint: https://bidder2.adquery.io/prebid/bid |
There was a problem hiding this comment.
% curl -i https://bidder2.adquery.io/prebid/bid
HTTP/2 204
server: nginx/1.18.0 (Ubuntu)
date: Tue, 14 Nov 2023 11:45:28 GMT
x-adq-t: r:1123;p:0;
cache-control: max-age=-172800, must-revalidate, private
pragma: no-cache
expires: Sun, 12 Nov 2023 11:45:28 GMT
access-control-allow-origin: *
access-control-allow-methods: POST, GET, OPTIONS, DELETE, PUT
access-control-max-age: 1000
access-control-allow-headers: x-requested-with, Content-Type, origin, authorization, accept, client-security-token
curl: (56) HTTP/2 stream 1 was reset
endpoint is reachable
onkarvhanumante
approved these changes
Nov 16, 2023
Sonali-More-Xandr
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.