Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bliink: iframe added to usersync #3243

Merged
merged 10 commits into from
Nov 23, 2023
Merged

Conversation

LouisBillaut
Copy link
Contributor

iframe added to usersync

Comment on lines +18 to +20
iframe:
url: "https://tag.bliink.io/usersync.html?gdpr={{.GDPR}}&gdprConsent={{.GDPRConsent}}&uspConsent={{.USPrivacy}}&redirect={{.RedirectURL}}"
userMacro: "$UID"
Copy link
Contributor

@onkarvhanumante onkarvhanumante Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@LouisBillaut LouisBillaut Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkarvhanumante Hi, the redirect is loaded directly into the iframe
is it ok ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkarvhanumante Hi, the redirect is loaded directly into the iframe is it ok ?

UUID was not populated in rediect url inside iframe html tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @onkarvhanumante, we have solved the issue. Is it ok now ?

Copy link
Contributor

@onkarvhanumante onkarvhanumante Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dbliink%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%24UID

@LouisBillaut tested out above url. UID is not replaced in redirect url. Could you check above url. HTML doesn't include iframe for above url

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouisBillaut requesting to address above comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouisBillaut requesting to address above comment

Hi @onkarvhanumante,
we've done a fix, now it should work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouisBillaut requesting to address above comment

Hi @onkarvhanumante, we've done a fix, now it should work.

fix seems to be working

@Sonali-More-Xandr Sonali-More-Xandr merged commit 8419142 into prebid:master Nov 23, 2023
3 checks passed
SuprPhatAnon pushed a commit to GiftConnect/prebid-server that referenced this pull request Dec 7, 2023
Co-authored-by: louisbillaut <[email protected]>
Co-authored-by: samous <[email protected]>
Co-authored-by: nowfeel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants