Adapter Name Case Insensitive: dealTier #3218
Conversation
| if bidderNormalized, bidderFound := NormalizeBidderName(bidder); bidderFound { | ||
| dealTiers[bidderNormalized] = *param.DealTier | ||
| } |
There was a problem hiding this comment.
The deal tier map being created here from the original request has keys that are the normalized bidder names. This map is then used in applyDealSupport but that function does not appear to alter the bidder name in winningBidsByBidder topBidsPerImp prior to checking if the bidder has any deal tiers in the deal tier map. Is a change needed in applyDealSupport as well?
There was a problem hiding this comment.
Good catch. Modified.
|
|
||
| bidderNormalized, bidderFound := openrtb_ext.NormalizeBidderName(bidder.String()) | ||
| if !bidderFound { | ||
| continue |
There was a problem hiding this comment.
This line isn't covered by tests, do you think you can add a test where the bidder is not found from the NormalizeBidderName call?
There was a problem hiding this comment.
Done. Also refactored TestApplyDealSupport a little bit.
|
While testing this PR I found that deals don't work with stored bid responses. This happens because impressions with stored bid response are removed from bidRequest and |
Function
ReadDealTiersFromImpunmarshals theImp.Extand creates a map of bidder names to deal tier info. This pull request normalizes the keys of this entries in this map in order to compare to the normalized bidder names and apply deal tiers if needed.