Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate limelight aliases to follow new pattern #3183

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

onkarvhanumante
Copy link
Contributor

This PR migrates limelight alias to use new pattern. This streamlined method for creating an alias in Prebid Server eliminates the code needed to create an alias and relies on just one configuration file.
The configuration file now contains only essential information for alias creation, with all other details derived from its parent.

Testing details:

Following are the alias of limelight digital

openrtb_ext.BidderAdsyield:          limelightDigital.Builder,
openrtb_ext.BidderAppstock:          limelightDigital.Builder,
openrtb_ext.BidderEvtech:            limelightDigital.Builder,
openrtb_ext.BidderGreedygame:        limelightDigital.Builder,
openrtb_ext.BidderIionads:           limelightDigital.Builder,
openrtb_ext.BidderXtrmqb:            limelightDigital.Builder,

 

/info/bidders/[bidder-name]
returns response for all aliases

localhost:8000/info/bidders/adsyield

{
    "status": "ACTIVE",
    "usesHttps": false,
    "maintainer": {
        "email": "[email protected]"
    },
    "capabilities": {
        "app": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        },
        "site": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        }
    }
}

localhost:8000/info/bidders/appstock

{
    "status": "ACTIVE",
    "usesHttps": false,
    "maintainer": {
        "email": "[email protected]"
    },
    "capabilities": {
        "app": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        },
        "site": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        }
    }
}

localhost:8000/info/bidders/evtech
{
    "status": "ACTIVE",
    "usesHttps": false,
    "maintainer": {
        "email": "[email protected]"
    },
    "capabilities": {
        "app": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        },
        "site": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        }
    }
}

localhost:8000/info/bidders/greedygame
{
    "status": "ACTIVE",
    "usesHttps": false,
    "maintainer": {
        "email": "[email protected]"
    },
    "capabilities": {
        "app": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        },
        "site": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        }
    }
}


localhost:8000/info/bidders/iionads
{
    "status": "ACTIVE",
    "usesHttps": false,
    "maintainer": {
        "email": "[email protected]"
    },
    "capabilities": {
        "app": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        },
        "site": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        }
    }
}

localhost:8000/info/bidders/xtrmqb
{
    "status": "ACTIVE",
    "usesHttps": false,
    "maintainer": {
        "email": "[email protected]"
    },
    "capabilities": {
        "app": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        },
        "site": {
            "mediaTypes": [
                "banner",
                "video",
                "audio",
                "native"
            ]
        }
    }
}

 
/info/bidders
response include all aliases of limelight digital

 curl --location 'localhost:8000/info/bidders' | jq . | grep 'adsyield|appstock|evtech|greedygame|iionads|xtrmqb'
 % Total % Received % Xferd Average Speed Time Time Time Current
 Dload Upload Total Spent Left Speed
 100 2200 0 2200 0 0 445k 0 --:--:-- --:--:-- --:--:-- 2148k
 "adsyield",
 "appstock",
 "evtech",
 "greedygame",
 "iionads",
 "xtrmqb",

 

/cookie_sync
Bidder info yaml defines syncer only for evtech bidder. As shown below endpoint returns iframe syncer cfg in response

curl --location 'localhost:8000/cookie_sync' \
--header 'Content-Type: application/json' \
--data '{
    "bidders": [
        "evtech"
    ],
    "coopsync": false,
    "limit": 1
}'

Response:
{
    "status": "no_cookie",
    "bidder_status": [
        {
            "bidder": "evtech",
            "no_cookie": true,
            "usersync": {
                "url": "https://tracker.direct.e-volution.ai/sync.html?gdpr=&consent=&us_privacy=&redirect=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3Devtech%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%7BPLL_USER_ID%7D",
                "type": "iframe"
            }
        }
    ]
}

- add aliasOf field in bidder info files
- removed entries from alias bidder info file {bidder-name}.yaml that are already present in parent
- removed alias bidder param files
Comment on lines 3 to 4
maintainer:
email: "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is same as parent and can be ommited.

Copy link
Contributor Author

@onkarvhanumante onkarvhanumante Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e595fdd

good catch @gargcreation1992

@imedvedko new change was pushed in e595fdd commit. PTAL

Evtech is alias of Limelight. Evtech and Limelight has same maintainer email.

As per Adapter alias, if alias uses same maintainer email then no need to mention it separately in alias bidder-info yaml.

PBS server on startup, will inherit parent maintainer email as alias maintainer email.
@Sonali-More-Xandr Sonali-More-Xandr self-assigned this Oct 16, 2023
@onkarvhanumante onkarvhanumante merged commit 91881fe into master Oct 18, 2023
3 checks passed
@SyntaxNode SyntaxNode deleted the adapter-alias/update-limelight-aliases branch November 17, 2023 22:13
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants