migrate adform alias to use new pattern

exchange/adapter_builders.go

@@ -193,7 +193,6 @@ func newAdapterBuilders() map[openrtb_ext.BidderName]adapters.Builder {
 		openrtb_ext.BidderAceex:             aceex.Builder,
 		openrtb_ext.BidderAcuityAds:         acuityads.Builder,
 		openrtb_ext.BidderAdf:               adf.Builder,
-		openrtb_ext.BidderAdform:            adf.Builder,
 		openrtb_ext.BidderAdgeneration:      adgeneration.Builder,
 		openrtb_ext.BidderAdhese:            adhese.Builder,
 		openrtb_ext.BidderAdkernel:          adkernel.Builder,

exchange/adapter_util.go

@@ -33,10 +33,6 @@ func buildBidders(infos config.BidderInfos, builders map[openrtb_ext.BidderName]
 	var errs []error
 
 	for bidder, info := range infos {
-		if len(info.AliasOf) > 0 {
-			errs = append(errs, fmt.Errorf("This feature is currently under development"))
-			continue
-		}
 		bidderName, bidderNameFound := openrtb_ext.NormalizeBidderName(bidder)
 		if !bidderNameFound {
 			errs = append(errs, fmt.Errorf("%v: unknown bidder", bidder))

exchange/adapter_util_test.go

@@ -68,13 +68,6 @@ func TestBuildAdapters(t *testing.T) {
 				errors.New("unknown: unknown bidder"),
 			},
 		},
-		{
-			description: "Alias feature disabled",
-			bidderInfos: map[string]config.BidderInfo{"appNexus": {AliasOf: "rubicon"}},
-			expectedErrors: []error{
-				errors.New("This feature is currently under development"),
-			},
-		},
 	}
 
 	cfg := &config.Configuration{}

openrtb_ext/bidders.go

@@ -23,7 +23,6 @@ var coreBidderNames []BidderName = []BidderName{
 	BidderAceex,
 	BidderAcuityAds,
 	BidderAdf,
-	BidderAdform,
 	BidderAdgeneration,
 	BidderAdhese,
 	BidderAdkernel,
@@ -311,7 +310,6 @@ const (
 	BidderAceex             BidderName = "aceex"
 	BidderAcuityAds         BidderName = "acuityads"
 	BidderAdf               BidderName = "adf"
-	BidderAdform            BidderName = "adform"
 	BidderAdgeneration      BidderName = "adgeneration"
 	BidderAdhese            BidderName = "adhese"
 	BidderAdkernel          BidderName = "adkernel"

static/bidder-info/adform.yaml

@@ -1,19 +1 @@
-endpoint: "https://adx.adform.net/adx/openrtb"
-maintainer:
-  email: "[email protected]"
-gvlVendorID: 50
-capabilities:
-  app:
-    mediaTypes:
-      - banner
-      - native
-      - video
-  site:
-    mediaTypes:
-      - banner
-      - native
-      - video
-userSync:
-  redirect:
-    url: "https://cm.adform.net/cookie?redirect_url={{.RedirectURL}}"
-    userMacro: "$UID"
+aliasOf: adf