Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: DXKulture #3176

Merged

Conversation

bev-devops
Copy link
Contributor

@bev-devops bev-devops commented Oct 4, 2023

🏷 Type of change

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@bev-devops bev-devops changed the title DXKulture adapter New Adapter: DXKulture Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 98860a1

dxkulture

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/dxkulture/dxkulture.go:27:	Builder		100.0%
github.com/prebid/prebid-server/adapters/dxkulture/dxkulture.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/adapters/dxkulture/dxkulture.go:74:	MakeBids	100.0%
github.com/prebid/prebid-server/adapters/dxkulture/dxkulture.go:112:	getBidType	100.0%
github.com/prebid/prebid-server/adapters/dxkulture/dxkulture.go:121:	parseExt	100.0%
github.com/prebid/prebid-server/adapters/dxkulture/dxkulture.go:141:	getHeaders	100.0%
total:									(statements)	97.1%

@@ -0,0 +1,16 @@
endpoint: "https://ads.kulture.media/pbs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is reachable

 % curl -i --request POST https://ads.kulture.media/pbs
HTTP/1.1 204 No Content
Date: Thu, 05 Oct 2023 19:30:07 GMT
Connection: keep-alive
Vary: Origin
Strict-Transport-Security: max-age=15724800; includeSubDomains

Comment on lines +15 to +16
url: "https://ads.kulture.media/usync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&cb={{.RedirectURL}}"
userMacro: "$UID"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@onkarvhanumante onkarvhanumante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

@onkarvhanumante onkarvhanumante merged commit 34ddf1a into prebid:master Oct 19, 2023
5 checks passed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
co-authored: @kmdevops
@clkoki clkoki deleted the create_dxkulture_adapter branch December 11, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants