Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Config Backwards Compatibility: Enable GZIP #3125

Conversation

bsardo
Copy link
Collaborator

@bsardo bsardo commented Sep 22, 2023

The upcoming 2.0 release will remove backwards compatibility for deprecated host and account configuration options. This PR removes support for the following host options:
enable_gzip

Instead, hosts should use compression.response.enable_gzip.

It should be noted that the migration logic being deleted here probably never worked to begin with because compression.response.enable_gzip was always set since it was being assigned a default value in viper.

@bsardo bsardo added the PBS 2.0 label Sep 22, 2023
@SyntaxNode SyntaxNode changed the title Remove host config compression backwards compatibility Remove Config Backwards Compatibility: Enable GZIP Sep 22, 2023
AlexBVolcy
AlexBVolcy previously approved these changes Sep 25, 2023
hhhjort
hhhjort previously approved these changes Sep 25, 2023
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo dismissed stale reviews from hhhjort and AlexBVolcy via e49db03 September 27, 2023 13:29
@bsardo bsardo merged commit fc36944 into prebid:master Sep 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants