Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubicon: Remove eids logic #3111

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Rubicon: Remove eids logic #3111

merged 2 commits into from
Sep 29, 2023

Conversation

SerhiiNahornyi
Copy link
Contributor

No description provided.

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6e9372f

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:183:	resolveVideoSizeId			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:201:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:217:	Builder					100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:228:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:253:	MakeRequests				82.2%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:567:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:586:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:605:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:642:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:650:	updateImpRpTargetWithFpdAttributes	81.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:750:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:760:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:764:	addStringAttribute			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:768:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:772:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:802:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:811:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:839:	isStringArray				100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:849:	isBoolArray				100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:859:	convertToStringArray			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:870:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:878:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:887:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:907:	contains				75.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:916:	extractUserBuyerUID			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:930:	isVideo					100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:939:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:944:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:976:	setImpNative				82.4%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1005:	MakeBids				92.2%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1105:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1123:	resolveAdm				87.5%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1138:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1147:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				85.4%

@onkarvhanumante
Copy link
Contributor

@SerhiiNahornyi should also remove/update json test files related to eids

  • user-buyeruid-not-present-but-special-uid-with-other-stype-present.json
  • user-buyeruid-not-present-but-special-uid-with-ppuid-stype-present.json
  • user-buyeruid-present.json

@SerhiiNahornyi
Copy link
Contributor Author

@SerhiiNahornyi should also remove/update json test files related to eids

  • user-buyeruid-not-present-but-special-uid-with-other-stype-present.json
  • user-buyeruid-not-present-but-special-uid-with-ppuid-stype-present.json
  • user-buyeruid-present.json

Good catch, fixed!

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f470e93

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:183:	resolveVideoSizeId			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:201:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:217:	Builder					100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:228:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:253:	MakeRequests				82.2%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:567:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:586:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:605:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:642:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:650:	updateImpRpTargetWithFpdAttributes	81.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:750:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:760:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:764:	addStringAttribute			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:768:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:772:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:802:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:811:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:839:	isStringArray				100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:849:	isBoolArray				100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:859:	convertToStringArray			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:870:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:878:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:887:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:907:	contains				75.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:916:	extractUserBuyerUID			66.7%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:930:	isVideo					100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:939:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:944:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:976:	setImpNative				82.4%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1005:	MakeBids				92.2%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1105:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1123:	resolveAdm				87.5%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1138:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/adapters/rubicon/rubicon.go:1147:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				85.0%

@gargcreation1992 gargcreation1992 merged commit 9e14c09 into master Sep 29, 2023
5 checks passed
@gargcreation1992 gargcreation1992 deleted the rubicon/remove-eids-logic branch September 29, 2023 08:32
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

Assignees

@gargcreation1992 gargcreation1992

@onkarvhanumante onkarvhanumante

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SerhiiNahornyi @onkarvhanumante @gargcreation1992